From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>, Mel Gorman <mgorman@suse.de>
Cc: Thomas Hellstrom <thellstrom@vmware.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Calculate effective load even if local weight is 0
Date: Mon, 06 Jan 2014 09:00:33 -0500 [thread overview]
Message-ID: <52CAB701.2020505@redhat.com> (raw)
In-Reply-To: <20140106123519.GK31570@twins.programming.kicks-ass.net>
On 01/06/2014 07:35 AM, Peter Zijlstra wrote:
> On Mon, Jan 06, 2014 at 11:39:12AM +0000, Mel Gorman wrote:
>> wake_affine uses a weight of 0 for sync wakeups on the grounds that it
>> is assuming the waking task will sleep and not contribute to load in the
>> near future. In this case, we still want to calculate the effective load
>> of the sched entity hierarchy. As effective_load is no longer used by
>> task_numa_compare since commit fb13c7ee (sched/numa: Use a system-wide
>> search to find swap/migration candidates), this patch simply restores the
>> historical behaviour.
>
> Urgh.. yeah. We should merge this. Rik you ok with me adding a from and
> sob from you?
Yes, please do :)
Signed-off-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
next prev parent reply other threads:[~2014-01-06 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 11:39 [PATCH] sched: Calculate effective load even if local weight is 0 Mel Gorman
2014-01-06 12:34 ` Peter Zijlstra
2014-01-06 13:09 ` Mel Gorman
2014-01-06 12:35 ` Peter Zijlstra
2014-01-06 14:00 ` Rik van Riel [this message]
2014-01-12 18:42 ` [tip:sched/urgent] " tip-bot for Rik van Riel
2014-01-13 7:52 ` [PATCH] " Preeti Murthy
2014-01-17 14:56 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CAB701.2020505@redhat.com \
--to=riel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).