From: Sudarshan Rajagopalan <sudaraja@codeaurora.org>
To: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Gavin Shan <gshan@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Logan Gunthorpe <logang@deltatee.com>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Price <steven.price@arm.com>
Subject: Re: [PATCH v3] arm64/mm: add fallback option to allocate virtually contiguous memory
Date: Fri, 16 Oct 2020 11:49:02 -0700 [thread overview]
Message-ID: <541f79b6b5f3640c1e4978931ae93a38@codeaurora.org> (raw)
In-Reply-To: <20201015083605.GA4537@willie-the-truck>
On 2020-10-15 01:36, Will Deacon wrote:
> On Wed, Oct 14, 2020 at 05:51:23PM -0700, Sudarshan Rajagopalan wrote:
>> When section mappings are enabled, we allocate vmemmap pages from
>> physically continuous memory of size PMD_SIZE using
>> vmemmap_alloc_block_buf(). Section mappings are good to reduce TLB
>> pressure. But when system is highly fragmented and memory blocks are
>> being hot-added at runtime, its possible that such physically
>> continuous
>> memory allocations can fail. Rather than failing the memory hot-add
>> procedure, add a fallback option to allocate vmemmap pages from
>> discontinuous pages using vmemmap_populate_basepages().
>>
>> Signed-off-by: Sudarshan Rajagopalan <sudaraja@codeaurora.org>
>> Reviewed-by: Gavin Shan <gshan@redhat.com>
>> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will@kernel.org>
>> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Logan Gunthorpe <logang@deltatee.com>
>> Cc: David Hildenbrand <david@redhat.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Steven Price <steven.price@arm.com>
>> ---
>> arch/arm64/mm/mmu.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> Please can you fix the subject? I have three copies of "PATCH v3" from
> different days in my inbox. I know it sounds trivial, but getting these
> little things right really helps with review, especially when it's
> sitting
> amongst a sea of other patches.
Yes sure, sorry about that - will change it to "PATCH v4" to make it
stand out from other patches.
>
> Thanks,
>
> Will
Sudarshan
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-10-16 18:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 0:51 [PATCH v3] arm64/mm: add fallback option to allocate virtually contiguous memory Sudarshan Rajagopalan
2020-10-15 0:51 ` Sudarshan Rajagopalan
2020-10-15 8:36 ` Will Deacon
2020-10-16 18:49 ` Sudarshan Rajagopalan [this message]
2020-10-16 18:56 ` [PATCH v4] " Sudarshan Rajagopalan
2020-11-05 0:03 ` Sudarshan Rajagopalan
2020-11-06 14:38 ` Catalin Marinas
2020-11-06 13:43 ` Will Deacon
2020-10-16 18:56 ` Sudarshan Rajagopalan
2020-11-17 18:33 ` Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2020-10-12 23:05 [PATCH v3] " Sudarshan Rajagopalan
2020-10-12 23:05 ` Sudarshan Rajagopalan
2020-10-13 11:38 ` Anshuman Khandual
2020-10-15 0:54 ` Sudarshan Rajagopalan
2020-10-01 20:16 [PATCH v3] arm64/mm: add fallback option to allocate virtually Sudarshan Rajagopalan
2020-10-01 20:16 ` [PATCH v3] arm64/mm: add fallback option to allocate virtually contiguous memory Sudarshan Rajagopalan
2020-10-06 3:36 ` Anshuman Khandual
2020-10-12 2:54 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541f79b6b5f3640c1e4978931ae93a38@codeaurora.org \
--to=sudaraja@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mark.rutland@arm.com \
--cc=steven.price@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).