From: Sasha Levin <sasha.levin@oracle.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
akpm@linux-foundation.org, lauraa@codeaurora.org
Subject: Re: [PATCH v3 3/3] mm: cma: release trigger
Date: Thu, 29 Jan 2015 08:04:35 -0500 [thread overview]
Message-ID: <54CA2FE3.1000001@oracle.com> (raw)
In-Reply-To: <20150129075130.GB19607@js1304-P5Q-DELUXE>
On 01/29/2015 02:51 AM, Joonsoo Kim wrote:
> On Tue, Jan 27, 2015 at 09:22:57PM -0500, Sasha Levin wrote:
>> > +static int cma_free_mem(struct cma *cma, int count)
>> > +{
>> > + struct cma_mem *mem = NULL;
>> > +
>> > + while (count) {
>> > + mem = cma_get_entry_from_list(cma);
>> > + if (mem == NULL)
>> > + return 0;
>> > +
>> > + if (mem->n <= count) {
>> > + cma_release(cma, mem->p, mem->n);
>> > + count -= mem->n;
>> > + kfree(mem);
>> > + } else if (cma->order_per_bit == 0) {
>> > + cma_release(cma, mem->p, count);
>> > + mem->p += count;
>> > + mem->n -= count;
>> > + count = 0;
>> > + cma_add_to_cma_mem_list(cma, mem);
>> > + } else {
>> > + cma_add_to_cma_mem_list(cma, mem);
>> > + break;
>> > + }
>> > + }
> Hmm... I'm not sure we need to deal with "mem->m < count" case.
> It is not suitable for any cma_alloc/release usecase.
Maybe not, but the code in mm/cma.c supports that right now. If that
ever changes we can make appropriate changes here.
> And, I'd like to insert some error log to last case rather than
> silently ignoring the request.
I can add that.
Thanks,
Sasha
prev parent reply other threads:[~2015-01-29 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 2:22 [PATCH v3 0/3] mm: cma: debugfs access to CMA Sasha Levin
2015-01-28 2:22 ` [PATCH v3 1/3] mm: cma: debugfs interface Sasha Levin
2015-01-28 2:22 ` [PATCH v3 2/3] mm: cma: allocation trigger Sasha Levin
2015-01-28 2:22 ` [PATCH v3 3/3] mm: cma: release trigger Sasha Levin
2015-01-29 7:51 ` Joonsoo Kim
2015-01-29 13:04 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA2FE3.1000001@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).