Re: [PATCH v6 1/3] usb: Add Xen pvUSB protocol description

[Juergen Gross <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 2728 bytes --]

On 13.10.21 14:01, Greg KH wrote:
> On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:
>> Add the definition of pvUSB protocol used between the pvUSB frontend in
>> a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).
>>
>> This header was originally provided by Fujitsu for Xen based on Linux
>> 2.6.18.
>>
>> Changes are:
>> - adapt to Linux kernel style guide
>> - use Xen namespace
>> - add lots of comments
>> - don't use kernel internal defines
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> ---
>>   include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++++
>>   1 file changed, 421 insertions(+)
>>   create mode 100644 include/xen/interface/io/usbif.h
>>
>> diff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/io/usbif.h
>> new file mode 100644
>> index 000000000000..9494b1c9be99
>> --- /dev/null
>> +++ b/include/xen/interface/io/usbif.h
>> @@ -0,0 +1,421 @@
>> +/*
>> + * usbif.h
>> + *
>> + * USB I/O interface for Xen guest OSes.
>> + *
>> + * Copyright (C) 2009, FUJITSU LABORATORIES LTD.
>> + * Author: Noboru Iwamatsu <n_iwamatsu@jp.fujitsu.com>
>> + *
>> + * Permission is hereby granted, free of charge, to any person obtaining a copy
>> + * of this software and associated documentation files (the "Software"), to
>> + * deal in the Software without restriction, including without limitation the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + */
> 
> Please use a SPDX line and not license "boilerplate" text like this :(

Okay. Is this your only concern for this series? Or is it a blocking
point for you before looking into it in more detail?

IOW: does it make sense for me to wait for further comments before
sending a new version of the series?


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]