From: Lars-Peter Clausen <lars@metafoo.de>
To: Kevin Cernekee <cernekee@chromium.org>,
lgirdwood@gmail.com, broonie@kernel.org
Cc: dgreid@chromium.org, abrestic@chromium.org, olofj@chromium.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset
Date: Mon, 04 May 2015 08:38:21 +0200 [thread overview]
Message-ID: <554713DD.4020006@metafoo.de> (raw)
In-Reply-To: <1430697619-22773-2-git-send-email-cernekee@chromium.org>
On 05/04/2015 02:00 AM, Kevin Cernekee wrote:
> Existing regmap users call regcache_mark_dirty() as part of the
> suspend/resume sequence, to tell regcache that non-default values need to
> be resynced post-resume. Add an internal "no_sync_defaults" regmap flag
> to remember this state, so that regcache_sync() can differentiate between
> these two cases:
>
> 1) HW was reset, so any cache values that match map->reg_defaults can be
> safely skipped. On some chips there are a lot of registers in the
> reg_defaults list, so this optimization speeds things up quite a bit.
>
> 2) HW was not reset (maybe it was just clock-gated), so if we cached
> any writes, they should be sent to the hardware regardless of whether
> they match the HW default. Currently this will write out all values in
> the regcache, since we don't maintain per-register dirty bits.
>
> Suggested-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Kevin Cernekee <cernekee@chromium.org>
> ---
> drivers/base/regmap/internal.h | 3 +++
> drivers/base/regmap/regcache.c | 61 ++++++++++++++++++++++++++++--------------
> 2 files changed, 44 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
> index a13587b5c2be..b2b2849fc6d3 100644
> --- a/drivers/base/regmap/internal.h
> +++ b/drivers/base/regmap/internal.h
> @@ -131,7 +131,10 @@ struct regmap {
> struct reg_default *reg_defaults;
> const void *reg_defaults_raw;
> void *cache;
> + /* if set, the cache contains newer data than the HW */
> u32 cache_dirty;
> + /* if set, the HW registers are known to match map->reg_defaults */
> + bool no_sync_defaults;
>
> struct reg_default *patch;
> int patch_regs;
> diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
> index 7eb7b3b98794..63af3103d0c6 100644
> --- a/drivers/base/regmap/regcache.c
> +++ b/drivers/base/regmap/regcache.c
> @@ -253,6 +253,9 @@ static int regcache_default_sync(struct regmap *map, unsigned int min,
> unsigned int max)
> {
> unsigned int reg;
> + bool no_sync_defaults = map->no_sync_defaults;
> +
> + map->no_sync_defaults = false;
This needs to be done at the end in regcache_sync(), the same place where
dirty is set to false.
>
> for (reg = min; reg <= max; reg += map->reg_stride) {
> unsigned int val;
> @@ -266,10 +269,12 @@ static int regcache_default_sync(struct regmap *map, unsigned int min,
> if (ret)
> return ret;
>
> - /* Is this the hardware default? If so skip. */
> - ret = regcache_lookup_reg(map, reg);
> - if (ret >= 0 && val == map->reg_defaults[ret].def)
> - continue;
> + if (no_sync_defaults) {
> + /* Is this the hardware default? If so skip. */
> + ret = regcache_lookup_reg(map, reg);
> + if (ret >= 0 && val == map->reg_defaults[ret].def)
> + continue;
> + }
This should go into a helper function regacache_reg_needs_sync() so it can
be reused at the other places where the same logic is needed.
next prev parent reply other threads:[~2015-05-04 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 0:00 [PATCH V3 0/4] tas571x amplifier driver Kevin Cernekee
2015-05-04 0:00 ` [PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset Kevin Cernekee
2015-05-04 6:38 ` Lars-Peter Clausen [this message]
2015-05-04 14:05 ` Kevin Cernekee
2015-05-04 17:33 ` Lars-Peter Clausen
2015-05-04 0:00 ` [PATCH V3 2/4] ASoC: tas571x: Add DT binding document Kevin Cernekee
2015-05-04 0:00 ` [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers Kevin Cernekee
2015-05-04 11:45 ` Mark Brown
2015-05-04 13:51 ` Kevin Cernekee
2015-05-04 13:57 ` Mark Brown
2015-05-04 0:00 ` [PATCH V3 4/4] MAINTAINERS: Add entry for tas571x ASoC codec driver Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554713DD.4020006@metafoo.de \
--to=lars@metafoo.de \
--cc=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cernekee@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).