From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Pali Rohár" <pali.rohar@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Pavel Machek" <pavel@ucw.cz>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
maxx <maxx@spaceboyz.net>
Subject: Re: [PATCH] radio-bcm2048: Fix region selection
Date: Fri, 05 Jun 2015 13:36:40 +0200 [thread overview]
Message-ID: <557189C8.7040203@xs4all.nl> (raw)
In-Reply-To: <1431725571-7417-1-git-send-email-pali.rohar@gmail.com>
On 05/15/2015 11:32 PM, Pali Rohár wrote:
> From: maxx <maxx@spaceboyz.net>
>
> This actually fixes region selection for BCM2048 FM receiver. To select
> the japanese FM-band an additional bit in FM_CTRL register needs to be
> set. This might not sound so important but it enables at least me to
> listen to some 'very interesting' radio transmission below normal
> FM-band.
>
> Patch writen by maxx@spaceboyz.net
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> Cc: maxx@spaceboyz.net
Looks good to me. If someone can repost with correct names and SoBs, then I'll
apply.
Regards,
Hans
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index aeb6c3c..1482d4b 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -739,7 +739,20 @@ static int bcm2048_set_region(struct bcm2048_device *bdev, u8 region)
> return -EINVAL;
>
> mutex_lock(&bdev->mutex);
> +
> bdev->region_info = region_configs[region];
> +
> + bdev->cache_fm_ctrl &= ~BCM2048_BAND_SELECT;
> + if (region > 2) {
> + bdev->cache_fm_ctrl |= BCM2048_BAND_SELECT;
> + err = bcm2048_send_command(bdev, BCM2048_I2C_FM_CTRL,
> + bdev->cache_fm_ctrl);
> + if (err) {
> + mutex_unlock(&bdev->mutex);
> + goto done;
> + }
> + }
> +
> mutex_unlock(&bdev->mutex);
>
> if (bdev->frequency < region_configs[region].bottom_frequency ||
>
next prev parent reply other threads:[~2015-06-05 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 21:32 [PATCH] radio-bcm2048: Fix region selection Pali Rohár
2015-05-15 22:51 ` Greg Kroah-Hartman
2015-06-05 11:36 ` Hans Verkuil [this message]
2015-06-05 12:01 ` Pali Rohár
2015-06-09 11:44 ` [PATCH v2] " Pali Rohár
2015-05-16 11:22 [PATCH] " Jan Roemisch
2015-05-16 14:06 ` Greg KH
2015-05-16 15:20 ` Jan Roemisch
2015-05-18 10:52 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557189C8.7040203@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxx@spaceboyz.net \
--cc=mchehab@osg.samsung.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).