From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: vjitta@codeaurora.org, Minchan Kim <minchan@kernel.org>,
Alexander Potapenko <glider@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Mark Brown <broonie@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
ylal@codeaurora.org, vinmenon@codeaurora.org,
kasan-dev <kasan-dev@googlegroups.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Qian Cai <qcai@redhat.com>
Subject: Re: [PATCH v2] lib: stackdepot: Add support to configure STACK_HASH_SIZE
Date: Thu, 3 Dec 2020 17:26:59 +0000 [thread overview]
Message-ID: <55b7ba6e-6282-2cf6-c42c-272bdd23a607@arm.com> (raw)
In-Reply-To: <ff00097b-e547-185d-2a1a-ce0194629659@arm.com>
On 12/3/20 4:34 PM, Vincenzo Frascino wrote:
> Hi Andrey,
>
> On 12/3/20 4:15 PM, Andrey Konovalov wrote:
>> On Thu, Dec 3, 2020 at 5:04 PM Qian Cai <qcai@redhat.com> wrote:
>>>
>>> On Thu, 2020-11-26 at 10:13 +0530, vjitta@codeaurora.org wrote:
>>>> From: Yogesh Lal <ylal@codeaurora.org>
>>>>
>>>> Add a kernel parameter stack_hash_order to configure STACK_HASH_SIZE.
>>>>
>>>> Aim is to have configurable value for STACK_HASH_SIZE, so that one
>>>> can configure it depending on usecase there by reducing the static
>>>> memory overhead.
>>>>
>>>> One example is of Page Owner, default value of STACK_HASH_SIZE lead
>>>> stack depot to consume 8MB of static memory. Making it configurable
>>>> and use lower value helps to enable features like CONFIG_PAGE_OWNER
>>>> without any significant overhead.
>>>>
>>>> Suggested-by: Minchan Kim <minchan@kernel.org>
>>>> Signed-off-by: Yogesh Lal <ylal@codeaurora.org>
>>>> Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org>
>>>
>>> Reverting this commit on today's linux-next fixed boot crash with KASAN.
>>>
>>> .config:
>>> https://cailca.coding.net/public/linux/mm/git/files/master/x86.config
>>> https://cailca.coding.net/public/linux/mm/git/files/master/arm64.config
>>
>> Vincenzo, Catalin, looks like this is the cause of the crash you
>> observed. Reverting this commit from next-20201203 fixes KASAN for me.
>>
>> Thanks for the report Qian!
>>
>
> Thank you for this. I will try and let you know as well.
>
Reverting the patch above works for me as well, and the problem seems to be the
order on which the initcalls are invoked. In fact stackdepot should be
initialized before kasan from what I can see.
--
Regards,
Vincenzo
next prev parent reply other threads:[~2020-12-03 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 4:43 [PATCH v2] lib: stackdepot: Add support to configure STACK_HASH_SIZE vjitta
2020-12-03 16:03 ` Qian Cai
2020-12-03 16:15 ` Andrey Konovalov
2020-12-03 16:34 ` Vincenzo Frascino
2020-12-03 17:26 ` Vincenzo Frascino [this message]
2020-12-03 20:32 ` Andrew Morton
2020-12-03 21:21 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55b7ba6e-6282-2cf6-c42c-272bdd23a607@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=minchan@kernel.org \
--cc=qcai@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=vinmenon@codeaurora.org \
--cc=vjitta@codeaurora.org \
--cc=ylal@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).