From: Flavio Suligoi <f.suligoi@asem.it>
To: Randy Dunlap <rdunlap@infradead.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/2] watchdog: add global watchdog kernel module parameters structure
Date: Tue, 9 Mar 2021 10:38:48 +0000 [thread overview]
Message-ID: <5689370584614335b4f43660d80a5338@asem.it> (raw)
In-Reply-To: <0e203992-cbff-738f-4629-368578cb992d@infradead.org>
> Hi,
>
Hi Randy,
> On 3/8/21 3:21 AM, Flavio Suligoi wrote:
> > Different watchdog modules frequently require the same type of
> > parameters (for example: timeout, nowayout feature, start wdog on
> > module insertion, etc.).
...
> > +In this way, each driver can read these "global" parameters and then,
> > +if needed, can implement them, according to the particular hw
> > +watchdog
>
> Please spell out "hardware" (not "hw").
Ok!
>
> > +characteristic.
> > +
> > +Using this approach, it is possible reduce some duplicate code in the
> > +*new*
>
> possible to reduce
Thanks!
...
> > + * Instead of add this kind of module parameters independently to
> > +each driver,
>
> adding
Thanks!
...
> > + * if needed, implements them, according to the particular hw
> > + watchdog
>
> s/hw/hardware/
Ok
...
> If I were doing (or using) this, I would probably want 'test_mode' and
> 'verbosity' to be unsigned int masks instead of a bool, so that there could be
> multiple types of test_mode or verbosity.
I used bool as already done in some watchdog drivers, but your suggestion
is better, thanks.
> That's something that some other subsystems do, but maybe watchdog is
> simple enough that it's not needed.
> If it is needed, then we are back to each driver doing it its own way (until this
> patch is updated).
>
>
> HTH. thanks.
> --
> ~Randy
Thanks Randy.
Regards,
Flavio
next prev parent reply other threads:[~2021-03-09 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 11:21 [PATCH v1 0/2] Watchdog Core Global Parameters Flavio Suligoi
2021-03-08 11:21 ` [PATCH v1 1/2] watchdog: add global watchdog kernel module parameters structure Flavio Suligoi
2021-03-09 5:24 ` Randy Dunlap
2021-03-09 10:38 ` Flavio Suligoi [this message]
2021-03-08 11:21 ` [PATCH v1 2/2] watchdog: wdat: add start_enable global parameter Flavio Suligoi
2021-03-08 19:39 ` [PATCH v1 0/2] Watchdog Core Global Parameters Guenter Roeck
2021-03-09 10:26 ` Flavio Suligoi
2021-03-09 15:22 ` Guenter Roeck
2021-03-09 18:42 ` Jerry Hoemann
2021-03-09 20:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689370584614335b4f43660d80a5338@asem.it \
--to=f.suligoi@asem.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).