From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932906AbcCQI5U (ORCPT ); Thu, 17 Mar 2016 04:57:20 -0400 Received: from mail-by2on0061.outbound.protection.outlook.com ([207.46.100.61]:24744 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932234AbcCQI5M (ORCPT ); Thu, 17 Mar 2016 04:57:12 -0400 X-Greylist: delayed 935 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Mar 2016 04:57:12 EDT Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: linux-next: build failure after merge of the drm tree To: Stephen Rothwell , Dave Airlie References: <20160317154121.1b47aff1@canb.auug.org.au> CC: , , Alex Deucher From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <56EA6DAF.1010007@amd.com> Date: Thu, 17 Mar 2016 09:41:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160317154121.1b47aff1@canb.auug.org.au> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1254:a521:f094:b23d:78b5:e2d5] X-ClientProxiedBy: VI1PR05CA0033.eurprd05.prod.outlook.com (25.162.33.171) To CY1PR12MB0135.namprd12.prod.outlook.com (25.161.173.17) X-MS-Office365-Filtering-Correlation-Id: 5da2a757-f642-41a3-7678-08d34e3ff2ca X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0135;2:G3rN9TzpI+eWKS87GcO636QJCTvdtMfwN9qmr9ac7Efxs131ZAc5d98ZGBmo89JBGaKKXHsq3qjVoMgpX+ZLMoL4Yvt82jLi10hJevdvJg1rfP2BZ0W4NyQNhQCtqcpUwQHRpEJS9OK1tk9diiJ2lSac0E/d/t4yj4tC8bqX4EC5HeMbCcab+XA2U+90PGD/;3:aVR+tepc4QYWJ9ImPktFfRUw8DdsC94o7gVzCVZTAyrULfvL1KvGTSokmjiHcXlsaiSHuZGWjGvSdCvPx8AqMoeEK8GaQ66ZVJyqNppOHQKcWlPgWR+iwST5PuPo2ZVS;25:HqtodPES1mxejFo/7IP19Zu/CeeBOfo40tnHhMOYM9KBLeDONpAtpBDzrjAw+4Zuyz2dkmVnBTPPx5CDauf3PigZLbis9PxT30yV0UGf2Ej56lt95GLe9U1Oda2inEPnCcrEiIv7B3dGovakzsIeStn0C9o0fQzgM6zmP6NjlmLptkApy8/psyCScpVGseL5VcuyiOPa4gkyFllZRRTf57glS/EKjZuKianD4gfW+R9g6PowGzP8uGxf/bLKsbYlqhiLO3TCEKDFjbyfa6FFrD8B2N6zGuIs7sKQzcgK9TYlO4+QFwozh5KFhFqj5iLGA3vnHKEohcR29Fk3JhzPfw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0135; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0135;20:k8YiTb6e9p756PAUoaMuOzdWTAdKtb2gxflmyppWWVnI8ngp/l4AOMtvFHzFnyvPaGMabYaNmGvDI/znzYa3Me0M+3hqzsqONw/0ezLIQo5Sh7XBzw5eVhlIsc6WyDSXpUWs05R3PC8mq50rfvtIZPJtitSjip1q8K75+m2e2jEGGlAhSBimWqqVt59AOOgzlYKHtE/dkglK+AZETaGj21O53ojyLL48JTyiOeDqhRvGf0fjstTD3DjyoqRmxHH9nos4tY6NHpCIBGzOSPBjvKdRsXpmn6DJjj/r5GMMRwfErDaBBgrsPvxjVhyQJ1XPCUycdVpS/kiWLv9+IYJQHEMwzCu1uIGH3D+8fvsbd9s3QvLsMsDUg2KI26BmhJToov6R5OQB5TyBQQuLsBZtLkwVeTZpFdsCqdgOcfSEJSmSNiODWOjjrIgEmeFAfOZcZXHe6bHwVuPXYCbRXGdUQXOy4VnMiezKbToHeoJwCJbevfKfLxM+qVF273XwtZLz;4:uw5FBlccOGqlmNxqYuJ7KFycH/GaP0KbYQM+jyI8Zu+zu31D6TR+g807GQWmBggEYyoTQh0zvZhmJNxvaSfjPLk5NyGlaA4AF8LIs6A7B42i1hpxgrQXD5nVQZhprGDd+2q0q84VPQn1dVQetY9ZQtFfnZA9vv4Je0mZjuJk7kHF+P5M21vXqwyUTlZDcK4gx3oB5fYYsbi6EhNLnCr4TTb2YUc7lEjEuM4zxHyPsG5SgVNFcXKHlcUdQKBJaGHQXBIE28jOL08MBOnDh880x5EUtxFoU5V4nVVzV5dtZ0U9Esj9EAAAeVpS2b5hJwKloICbrBEF+q95dqe88OXLG/4N3Qu9Vv+Jnd3cvPQnKmjQU05QNDRYZWuGjkKpmUbR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR12MB0135;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0135; X-Forefront-PRVS: 0884AAA693 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(33656002)(83506001)(2950100001)(77096005)(6116002)(1096002)(586003)(2870700001)(4326007)(5001770100001)(19580395003)(80316001)(19580405001)(2906002)(189998001)(47776003)(5008740100001)(81166005)(65816999)(87266999)(54356999)(76176999)(50986999)(86362001)(92566002)(23746002)(42186005)(65806001)(59896002)(36756003)(5004730100002)(65956001)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0135;H:[IPv6:2a02:908:1254:a521:f094:b23d:78b5:e2d5];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR12MB0135;23:7zMdUUOvBQEein36uclsitCNpXt/imtNju6Wp?= =?Windows-1252?Q?UmaUNNUHklkyBJ2EVxG1u5tOqEALNzSJoL7iKWu9iXeGYe6bGv9CEwo6?= =?Windows-1252?Q?GdXqWWUKBbyq3YxRgTUu7P8yBc4u5d2vrsLdH5lYG2nlfYPpUydCFFa7?= =?Windows-1252?Q?6L0eCkVboPAvmV1DMiSLQhvQvWULp/KvmK2T8HkkzzMc7y9B2o4jqdKc?= =?Windows-1252?Q?bqtz4K2qJ+cXfjz2h3gawa4ZWJRrmepnoJaUXNzWEKtOmi5o877cJ+tQ?= =?Windows-1252?Q?5tT7iBYr1v/VRo1+Lil/fn6XGqv/1e8Wdhbkhp5Kj/iDPYFFl1OvmdVj?= =?Windows-1252?Q?w9DT6JD7cIr1NRg8ZqlVSgiGtnVKqJPw42uVuhsaD4rED7U9fyRBHpwU?= =?Windows-1252?Q?nA2NpLNvk6Nsxxyi4QEGhDnPdGJT1JccWbs+6S3EHjv4V70fsabyoR3e?= =?Windows-1252?Q?DfnKUXr/3lRLVbq9vGvXOnHrGmRIG5+dukZwA927aUVo3/J/eYfwVWf3?= =?Windows-1252?Q?73l8fjzB39SlTW+vOmcmc865ijdQoMdT42zHkXbCVg3PMZF4a1ZoH+d/?= =?Windows-1252?Q?iSmb0mX+qFdhbN0H2Tvx1HiclQGUlC/NpG+/GIYZt4Sf5FatlasAbGAv?= =?Windows-1252?Q?GbtIPDDTkyM7qbMsUOJmi1bAg/74ZiaVJU8SFRbxAwtlUdmPPBU2WNtM?= =?Windows-1252?Q?6bmqq8xABNoGOLYkEVsKDtjPt6/xUn4lKu0YXon7Uadcd5xtAqXnJsp4?= =?Windows-1252?Q?ugl1rexBMGSDf1Klq3UaXin/nOhnvN09CbR2eJZ73B7kPV8Yxr4CvkH1?= =?Windows-1252?Q?Gzvu/W9GSnQ9wWDXjCXKboDSUC49vtf7/QgWKQ/oQukK5+cwbXt8B9Zk?= =?Windows-1252?Q?1CnKduVuFZAHDsu/0pQxvV4G0OrA7YgzlApjpg4s6i7sqe5JMowQMNvF?= =?Windows-1252?Q?QRNPrKRH7kSfGGEzDjTUE5R/m8MGj265ZnAiC+T28XKsXFJukXWkl4pI?= =?Windows-1252?Q?f3pgjh8paytWhgV792VyZePNvmgN1YFZkENzMpYdyNT0/FqbQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0135;5:ZnoHQV5CkMiOpEE0FCS8HYx2zRpGB6NlpsB55japp5PzGEob2fDFD1NLYYaotKEgAZtMRmOcj7G5RxNyXDGuxiVBNC8RsLTQ/e+9wxROPsfvJWzP/3aYylJwc8EEvCLq3qEZT1fWyBB1G2Bf5Xiuqg==;24:cHvzu64MpW6tAeZPqKzJCcnQlTTChf1bj2u1HoW3MzkojiJA/QXxx0so5XkDSiJSb6ctGr9EF0XSKtNsniumkd5kayABCGxfwe+OZhoAVVA=;20:+eTVuUYzJUBKKesJfSAVh77vK5A/G23KkZOHOTFSvk6TB/IkW8KRr/gMe4SoMxmKOK5TweGwqqKB/c/rXcfz+0+niej9jLLfyATEa4+HvnPQ1Fk29IoIsVy6+kahRgo/7rOefr/mP7itVMBN+/BPE8RFL4dMbB932gkKNd2Xg3lzwLSJ4QUK0GPE8QZYuVf/4tGvkL7erh83hVcMs3vnvF+aF3B875Bhjjkat282qXeuxF+iPcZzuGwAozxB1pAc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2016 08:41:34.0136 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0135 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, yeah, indeed the release_pages() function is now used in two more files. Your fix is Reviewed-by: Christian König . Regards, Christian. Am 17.03.2016 um 05:41 schrieb Stephen Rothwell: > Hi Dave, > > After merging the drm tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c: In function 'amdgpu_gem_userptr_ioctl': > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:321:2: error: implicit declaration of function 'release_pages' [-Werror=implicit-function-declaration] > release_pages(bo->tbo.ttm->pages, bo->tbo.ttm->num_pages, false); > ^ > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c: In function 'amdgpu_cs_parser_bos': > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:410:5: error: implicit declaration of function 'release_pages' [-Werror=implicit-function-declaration] > release_pages(e->user_pages, > ^ > > Caused by commit > > 2f568dbd6b94 ("drm/amdgpu: move get_user_pages out of amdgpu_ttm_tt_pin_userptr v6") > > Presumably a forgotten include file. > > I added this fix patch for today: > > From: Stephen Rothwell > Date: Thu, 17 Mar 2016 15:30:49 +1100 > Subject: [PATCH] drm/amdgpu: release_pages requires linux/pagemap.h > > Signed-off-by: Stephen Rothwell > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index 4f5ef4149e87..9392e50a7ba4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -25,6 +25,7 @@ > * Jerome Glisse > */ > #include > +#include > #include > #include > #include "amdgpu.h" > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > index 1ecdf6c01368..0f2391ec1ed9 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > @@ -26,6 +26,7 @@ > * Jerome Glisse > */ > #include > +#include > #include > #include > #include "amdgpu.h"