From: Krzysztof Kozlowski <krzk@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 13/22] ARM: dts: exynos: Move common nodes to exynos5.dtsi
Date: Tue, 10 May 2016 07:30:38 +0200 [thread overview]
Message-ID: <573171FE.6070309@kernel.org> (raw)
In-Reply-To: <1cee1acf-fb07-9a7f-5d18-b4824a10f5a2@osg.samsung.com>
On 05/09/2016 11:25 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 05/08/2016 03:05 PM, Krzysztof Kozlowski wrote:
>> Exynos5420 and Exynos5250 share some nodes: the PWM and syscon
>> (sysreg_system_controller). Move them to parent DTSI to avoid
>> duplication.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> ---
>
> I see that the i2c_[0-3] nodes are also the same in both DTSI. Do you
> think that makes sense to also move those to exynos5.dtsi as well?
Thanks, that is a good suggestion. I didn't add the I2C and its children
to Odroid XU yet but probably having the nodes defined won't hurt.
Especially that they are disabled by default.
Best regards,
Krzysztof
> In any case that can be made as a follow-up, so:
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Best regards,
>
next prev parent reply other threads:[~2016-05-10 5:30 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 19:05 [PATCH v2 00/22] ARM: dts: exynos: Add initial support for Odroid XU Krzysztof Kozlowski
2016-05-08 19:05 ` [PATCH v2 01/22] dt-bindings: clock: Add license and reformat Exynos5410 clock IDs Krzysztof Kozlowski
2016-05-09 19:37 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 02/22] dt-bindings: clock: Add PWM and USB clock IDs to Exynos5410 Krzysztof Kozlowski
2016-05-09 19:41 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 03/22] ARM: dts: exynos: Add fin_pll node for clock driver Krzysztof Kozlowski
2016-05-09 19:53 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 04/22] clk: samsung: exynos5410: Provide fin_pll external fixed clock Krzysztof Kozlowski
2016-05-09 20:19 ` Javier Martinez Canillas
2016-05-10 5:26 ` Krzysztof Kozlowski
2016-05-08 19:05 ` [PATCH v2 05/22] ARM: dts: exynos: Switch MCT node to a new fin_pll clock Krzysztof Kozlowski
2016-05-09 20:22 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 06/22] ARM: dts: exynos: Remove old fixed-clock provider on SMDK5410 Krzysztof Kozlowski
2016-05-09 20:24 ` Javier Martinez Canillas
2016-05-10 5:27 ` Krzysztof Kozlowski
2016-05-08 19:05 ` [PATCH v2 07/22] clk: samsung: exynos5410: Rename fin_pll from temporary to regular name Krzysztof Kozlowski
2016-05-09 20:25 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 08/22] clk: samsung: exynos5410: Add serial3, USB and PWM clocks Krzysztof Kozlowski
2016-05-09 20:50 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 09/22] ARM: dts: exynos: Re-order alphabetically Exynos5420 SD0/SD1 pinctrl nodes Krzysztof Kozlowski
2016-05-09 20:52 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 10/22] ARM: dts: exynos: Use lowercase for Exynos5410 CPU node labels Krzysztof Kozlowski
2016-05-09 20:54 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 11/22] ARM: dts: exynos: Configure Exynos5410 pinctrl for eMMC and SD card Krzysztof Kozlowski
2016-05-09 20:58 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 12/22] ARM: dts: exynos: Split Odroid XU3 LEDs to separate DTSI Krzysztof Kozlowski
2016-05-09 20:59 ` Javier Martinez Canillas
2016-05-08 19:05 ` [PATCH v2 13/22] ARM: dts: exynos: Move common nodes to exynos5.dtsi Krzysztof Kozlowski
2016-05-09 21:25 ` Javier Martinez Canillas
2016-05-10 5:30 ` Krzysztof Kozlowski [this message]
2016-05-08 19:05 ` [PATCH v2 14/22] ARM: dts: exynos: Prepare for inclusion of exynos5.dtsi in exynos5410.dtsi Krzysztof Kozlowski
2016-05-09 21:27 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 15/22] ARM: dts: exynos: Use phandle to get parent node in exynos5250-snow Krzysztof Kozlowski
2016-05-09 21:29 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 16/22] ARM: dts: exynos: Move Exynos5250 and Exynos5420 nodes under soc Krzysztof Kozlowski
2016-05-09 21:35 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 17/22] ARM: dts: exynos: Include common exynos5 in exynos5410.dtsi Krzysztof Kozlowski
2016-05-09 21:39 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 18/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Krzysztof Kozlowski
2016-05-09 21:40 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 19/22] ARM: dts: exynos: MCT is not an interrupt controller and extend length of iomap Krzysztof Kozlowski
2016-05-09 21:44 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 20/22] ARM: dts: exynos: Move common Exynos5410/542x/5800 nodes to new DTSI Krzysztof Kozlowski
2016-05-09 21:53 ` Javier Martinez Canillas
2016-05-10 5:33 ` Krzysztof Kozlowski
2016-05-10 12:51 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 21/22] ARM: dts: exynos: Add USB to Exynos5410 Krzysztof Kozlowski
2016-05-09 21:55 ` Javier Martinez Canillas
2016-05-08 19:06 ` [PATCH v2 22/22] ARM: dts: exynos: Add initial support for Odroid XU board Krzysztof Kozlowski
2016-05-09 20:09 ` Rob Herring
2016-05-09 22:02 ` Javier Martinez Canillas
2016-05-10 5:35 ` Krzysztof Kozlowski
2016-05-09 22:00 ` [PATCH v2 00/22] ARM: dts: exynos: Add initial support for Odroid XU Stephen Boyd
2016-05-09 22:05 ` Javier Martinez Canillas
2016-05-10 5:13 ` Krzysztof Kozlowski
2016-05-10 14:00 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573171FE.6070309@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).