From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FD1C282D7 for ; Wed, 30 Jan 2019 15:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62D26205C9 for ; Wed, 30 Jan 2019 15:32:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20150623.gappssmtp.com header.i=@ndufresne-ca.20150623.gappssmtp.com header.b="0w0jjpO4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731468AbfA3Pcc (ORCPT ); Wed, 30 Jan 2019 10:32:32 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:42704 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727977AbfA3Pcc (ORCPT ); Wed, 30 Jan 2019 10:32:32 -0500 Received: by mail-qt1-f195.google.com with SMTP id d19so26628727qtq.9 for ; Wed, 30 Jan 2019 07:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=ogMbMWCbaPKXCxe13GQRtAoEFG/dyH2jH/CrprzGxr0=; b=0w0jjpO4fdNODtpHiNha+HZMbP1zY37miF06vcpSs4Q8y8Fc4dBEpJ7rQqlffiy+hs e2fawZtAwr+MPstTuEwB0s/byHTh7AONQMUADPrXbgHGuqZDG45kXq2F0JnAd9GYNsU7 2o/Tx+NJbt5rB4CdsqLZ2oFmK/iJpA1dDe8EV752GcT0j6GZ19cB4aUkgEbGraw6aYg9 gf4e70noWAYk2896OI0gixYSbKprCBAxYvh/lgtJkt0Hd60jBkWdWmhBomKLWdRY2AQM Qu6pH2Hk/E7ENOeLb1+iPS47d9nFmBG2evFYp00Z150NdLfz4+ZzlQ9uEPjhQdi/1cCH dGEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=ogMbMWCbaPKXCxe13GQRtAoEFG/dyH2jH/CrprzGxr0=; b=H8sqXAtuSMLXdd34/z5zKy6X1IXYxInsUwUeECXChr6Gwm5PFL8tMPqkan3FM9tHlA xGVbqotteNEE5zf6c8ngDzy3juj/KHhPpNKqLRrpLeniokHbcy0ApVS4tu2TdU73dfvH ypxk2j8RELgvq4mrijKpQ7epTyQrXl7BAcMnGc2mM9n13U6vi9tvX7Sb4nr4UVlCcN0b K3EDVxgjwAWL/GlduBWFJZEjjhPLLat8zb76cz91pa+O3ya/eIpnxknoULDg6K0xNHit eXX+C6046jVcqZjII+b3840I8m0HB7WXayLdGSOgVEYPPEfyaNXyfBwccFY7x5V016PE m8Cg== X-Gm-Message-State: AJcUukeDBTwHUev2E346rC492wpju4a2qhQeBG1yzKfeY95pQtXMErUC e9Z/EqwbSDbD6OXyoUlJ1BaWDA== X-Google-Smtp-Source: ALg8bN5IcFzRI6RW6sCe2/QhmafHaLe1WGIw06L3Fgvi9WnQXsKsNTJd7ZQAYv8mrMdEr6AtO1wrXg== X-Received: by 2002:a0c:c138:: with SMTP id f53mr28955133qvh.225.1548862351152; Wed, 30 Jan 2019 07:32:31 -0800 (PST) Received: from skullcanyon ([192.222.193.21]) by smtp.gmail.com with ESMTPSA id t40sm1367912qth.46.2019.01.30.07.32.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 07:32:30 -0800 (PST) Message-ID: <57419418d377f32d0e6978f4e4171c0da7357cbb.camel@ndufresne.ca> Subject: Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API From: Nicolas Dufresne To: Tomasz Figa Cc: Stanimir Varbanov , Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , Linux Kernel Mailing List , linux-arm-msm , Vikash Garodia , Alexandre Courbot , Malathi Gottam , Philipp Zabel Date: Wed, 30 Jan 2019 10:32:28 -0500 In-Reply-To: References: <20190117162008.25217-1-stanimir.varbanov@linaro.org> <20190117162008.25217-11-stanimir.varbanov@linaro.org> <28069a44-b188-6b89-2687-542fa762c00e@linaro.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.4 (3.30.4-1.fc29) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mercredi 30 janvier 2019 à 15:17 +0900, Tomasz Figa a écrit : > > I don't remember saying that, maybe I meant to say there might be a > > workaround ? > > > > For the fact, here we queue the headers (or first frame): > > > > https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/blob/master/sys/v4l2/gstv4l2videodec.c#L624 > > > > Then few line below this helper does G_FMT internally: > > > > https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/blob/master/sys/v4l2/gstv4l2videodec.c#L634 > > https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/blob/master/sys/v4l2/gstv4l2object.c#L3907 > > > > And just plainly fails if G_FMT returns an error of any type. This was > > how Kamil designed it initially for MFC driver. There was no other > > alternative back then (no EAGAIN yet either). > > Hmm, was that ffmpeg then? > > So would it just set the OUTPUT width and height to 0? Does it mean > that gstreamer doesn't work with coda and mtk-vcodec, which don't have > such wait in their g_fmt implementations? I don't know for MTK, I don't have the hardware and didn't integrate their vendor pixel format. For the CODA, I know it works, if there is no wait in the G_FMT, then I suppose we are being really lucky with the timing (it would be that the drivers process the SPS/PPS synchronously, and a simple lock in the G_FMT call is enough to wait). Adding Philipp in CC, he could explain how this works, I know they use GStreamer in production, and he would have fixed GStreamer already if that was causing important issue. Nicolas