From: Keerthy <a0393675@ti.com>
To: Eduardo Valentin <edubezval@gmail.com>, Rui Zhang <rui.zhang@intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv4 00/48] thermal: reorganizing thermal core
Date: Tue, 31 May 2016 15:12:15 +0530 [thread overview]
Message-ID: <574D5C77.30506@ti.com> (raw)
In-Reply-To: <1464675535-2433-1-git-send-email-edubezval@gmail.com>
On Tuesday 31 May 2016 11:48 AM, Eduardo Valentin wrote:
> Folks,
>
> This is V4 of a patch series to improve thermal core. The idea
> here is to reorganize the code and improve the way we
> handle sysfs entries.
>
> The change in behavior is that now, thermal zones with empty
> .type will not be allowed to be registered. Also, the way
> we handle scanf's return code is now checking for
> number of successful inputs.
>
> After this series, thermal core is split into the following files:
> - thermal_sysfs.c: contains the functions handling the sysfs nodes
> - thermal_helpers.c: groups functions that do not need to touch thermal
> core internal data structures, such as internal lists, and list locks.
> - thermal_core.c: functions to handle the lifecycle of the subsystem,
> its governors, cooling devices, thermal zone devices, and their
> interactions.
>
> I don't expect any impact on userspace.
>
> Please give your inputs.
>
> For your consideration, I am also adding this to this branch:
> git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal sysfs_rework
>
> V3->V4:
> - Fixes on a couple of sysfs entries as reported in the mailing list.
Boots fine on DRA7, DRA72, Beagle-x15. Checked all the temperatures of
various zones and tested emul_temp using:
https://lkml.org/lkml/2016/5/10/346
For DRA7/DRA72 and Beagle-x15.
Tested-by: Keerthy <j-keerthy@ti.com>
>
> V2->V3:
> - Included 8 extra patches to remove style issues on
> (new) thermal core.
>
> V1->V2:
> - Removed all checkpatch issues in the existing code that was
> moved/changed.
>
> Rui, it would be great if you could review these earlier. I will be
> sending two extra patch series on top of this one.
>
>
>
> Eduardo Valentin (48):
> thermal: core: prevent zones with no types to be registered
> thermal: core: group thermal_zone DEVICE_ATTR's declarations
> thermal: core: group device_create_file() calls that are always
> created
> thermal: core: use dev.groups to manage always present tz attributes
> thermal: core: move emul_temp creation to tz->device.groups
> thermal: core: move mode attribute to tz->device.groups
> thermal: core: move passive attr to tz->device.groups
> thermal: core: improve power actor documentation
> thermal: core: move power actor code out of sysfs I/F section
> thermal: core: remove useless empty line
> thermal: core: fix style on remove_trip_attrs()
> thermal: core: move the trip attrs to the tz sysfs I/F section
> thermal: core: create tz->device.groups dynamically
> thermal: core: move trips attributes to tz->device.groups
> thermal: core: remove unnecessary device_remove() calls
> thermal: core: split passive_store
> thermal: core: split policy_store
> thermal: core: split available_policies_show()
> thermal: core: move to_thermal_zone() macro to header file
> thermal: core: treat correctly the return value of *scanf calls
> thermal: core: match parenthesis on code alignment
> thermal: core: move thermal_zone sysfs to thermal_sysfs.c
> thermal: core: move to_cooling_device macro to header file
> thermal: core: move cooling device sysfs to thermal_sysfs.c
> thermal: core: remove a couple of style issues on helpers
> thermal: core: introduce thermal_helpers.c
> thermal: core: group functions related to governor handling
> thermal: core: move idr handling to device management section
> thermal: core: small style fix on __unbind() helper
> thermal: core: move __unbind() helper to where it is used
> thermal: core: move bind_cdev() to where it is used
> thermal: core: move bind_tz() to where it is used
> thermal: core: fix couple of style issues on __bind() helper
> thermal: core: move __bind() to where it is used
> thermal: core: add inline to print_bind_err_msg()
> thermal: core: move notify to the zone update section
> thermal: core: add a comment describing the main update loop
> thermal: core: add a comment describing the power actor section
> thermal: core: add a comment describing the device management section
> thermal: sysfs: remove symbols of emul_temp when config is disabled
> thermal: core: remove FSF address in the GPL notice
> thermal: core: small style fix when checking for __find_governor()
> thermal: core: standardize line breaking alignment
> thermal: core: remove void function return statements
> thermal: core: remove style warnings and checks
> thermal: core: improve kerneldoc entry of
> thermal_cooling_device_unregister
> thermal: core: use kzalloc(sizeof(*ptr),...)
> thermal: sysfs: use kcalloc() instead of kzalloc()
>
> drivers/thermal/Makefile | 3 +-
> drivers/thermal/thermal_core.c | 1363 +++++++++----------------------------
> drivers/thermal/thermal_core.h | 26 +
> drivers/thermal/thermal_helpers.c | 144 ++++
> drivers/thermal/thermal_sysfs.c | 756 ++++++++++++++++++++
> include/linux/thermal.h | 2 +
> 6 files changed, 1238 insertions(+), 1056 deletions(-)
> create mode 100644 drivers/thermal/thermal_helpers.c
> create mode 100644 drivers/thermal/thermal_sysfs.c
>
prev parent reply other threads:[~2016-05-31 9:42 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 6:18 [PATCHv4 00/48] thermal: reorganizing thermal core Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 01/48] thermal: core: prevent zones with no types to be registered Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 02/48] thermal: core: group thermal_zone DEVICE_ATTR's declarations Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 03/48] thermal: core: group device_create_file() calls that are always created Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 04/48] thermal: core: use dev.groups to manage always present tz attributes Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 05/48] thermal: core: move emul_temp creation to tz->device.groups Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 06/48] thermal: core: move mode attribute " Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 07/48] thermal: core: move passive attr " Eduardo Valentin
2016-06-16 3:27 ` Zhang Rui
2016-06-16 4:15 ` Zhang Rui
2016-05-31 6:18 ` [PATCHv4 08/48] thermal: core: improve power actor documentation Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 09/48] thermal: core: move power actor code out of sysfs I/F section Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 10/48] thermal: core: remove useless empty line Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 11/48] thermal: core: fix style on remove_trip_attrs() Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 12/48] thermal: core: move the trip attrs to the tz sysfs I/F section Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 13/48] thermal: core: create tz->device.groups dynamically Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 14/48] thermal: core: move trips attributes to tz->device.groups Eduardo Valentin
2016-06-17 8:44 ` Zhang Rui
2016-05-31 6:18 ` [PATCHv4 15/48] thermal: core: remove unnecessary device_remove() calls Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 16/48] thermal: core: split passive_store Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 17/48] thermal: core: split policy_store Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 18/48] thermal: core: split available_policies_show() Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 19/48] thermal: core: move to_thermal_zone() macro to header file Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 20/48] thermal: core: treat correctly the return value of *scanf calls Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 21/48] thermal: core: match parenthesis on code alignment Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 22/48] thermal: core: move thermal_zone sysfs to thermal_sysfs.c Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 23/48] thermal: core: move to_cooling_device macro to header file Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 24/48] thermal: core: move cooling device sysfs to thermal_sysfs.c Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 25/48] thermal: core: remove a couple of style issues on helpers Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 26/48] thermal: core: introduce thermal_helpers.c Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 27/48] thermal: core: group functions related to governor handling Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 28/48] thermal: core: move idr handling to device management section Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 29/48] thermal: core: small style fix on __unbind() helper Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 30/48] thermal: core: move __unbind() helper to where it is used Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 31/48] thermal: core: move bind_cdev() " Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 32/48] thermal: core: move bind_tz() " Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 33/48] thermal: core: fix couple of style issues on __bind() helper Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 34/48] thermal: core: move __bind() to where it is used Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 35/48] thermal: core: add inline to print_bind_err_msg() Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 36/48] thermal: core: move notify to the zone update section Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 37/48] thermal: core: add a comment describing the main update loop Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 38/48] thermal: core: add a comment describing the power actor section Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 39/48] thermal: core: add a comment describing the device management section Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 40/48] thermal: sysfs: remove symbols of emul_temp when config is disabled Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 41/48] thermal: core: remove FSF address in the GPL notice Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 42/48] thermal: core: small style fix when checking for __find_governor() Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 43/48] thermal: core: standardize line breaking alignment Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 44/48] thermal: core: remove void function return statements Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 45/48] thermal: core: remove style warnings and checks Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 46/48] thermal: core: improve kerneldoc entry of thermal_cooling_device_unregister Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 47/48] thermal: core: use kzalloc(sizeof(*ptr),...) Eduardo Valentin
2016-05-31 6:18 ` [PATCHv4 48/48] thermal: sysfs: use kcalloc() instead of kzalloc() Eduardo Valentin
2016-05-31 9:42 ` Keerthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574D5C77.30506@ti.com \
--to=a0393675@ti.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).