linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xing Zheng <zhengxing@rock-chips.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-rockchip@lists.infradead.org, dianders@chromium.org,
	heiko@sntech.de, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219
Date: Fri, 03 Jun 2016 22:16:12 +0800	[thread overview]
Message-ID: <5751912C.6080904@rock-chips.com> (raw)
In-Reply-To: <20160601144542.GA3835@rob-hp-laptop>

Hi Rob,

On 2016年06月01日 22:45, Rob Herring wrote:
> On Thu, May 26, 2016 at 09:02:22PM +0800, Xing Zheng wrote:
>> There are multi codec devices on the RK3399 platform, we can use
>> this patch support and control these codecs.
>>
>> Signed-off-by: Xing Zheng<zhengxing@rock-chips.com>
>> ---
>>
>> Changes in v3:
>> - rename DOC to rockchip,rk3399-max98357a-rt5514-da7219.txt
>> - rename compatible to rockchip,rk3399-max98357a-rt5514-da7219
>> - rename source code to rk3399_max98357a_rt5514_da7219.c
>>
>> Changes in v2:
>> - use the FS 256 to set mclks of the max98357a and rt5514 danamically
>> - add more sample rate for da7219
>>
>>   .../rockchip,rk3399-max98357a-rt5514-da7219.txt    |   15 +
>>   sound/soc/rockchip/Kconfig                         |   11 +
>>   sound/soc/rockchip/Makefile                        |    2 +
>>   .../soc/rockchip/rk3399_max98357a_rt5514_da7219.c  |  333 ++++++++++++++++++++
>>   4 files changed, 361 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3399-max98357a-rt5514-da7219.txt
>>   create mode 100644 sound/soc/rockchip/rk3399_max98357a_rt5514_da7219.c
>>
>> diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3399-max98357a-rt5514-da7219.txt b/Documentation/devicetree/bindings/sound/rockchip,rk3399-max98357a-rt5514-da7219.txt
>> new file mode 100644
>> index 0000000..3ae603e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3399-max98357a-rt5514-da7219.txt
>> @@ -0,0 +1,15 @@
>> +ROCKCHIP with MAX98357A/RT5514/DA7219 codecs
>> +
>> +Required properties:
>> +- compatible: "rockchip,rk3399-max98357a-rt5514-da7219"
> I'm still not very clear on the naming convention thoughout this. This
> doesn't seem like a pattern we want to repeat (<chip>-<codec>-<codec>).
>
Thank you for your reply. :-)

I refered to MTK's mt8173-rt5650-rt5514.txt on upstream, that compatible 
name is "mediatek,mt8173-rt5650-rt5514".
Because our platform need to support 3 codecs (max98357a / da7219 / 
rt5514). Perhaps, you maybe feel that name is too long? And, could you 
please tell me what names would be better?

For example: "rk3399-composite-codecs" ?

Thanks.


-- 
- Xing Zheng

  reply	other threads:[~2016-06-03 14:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 13:02 [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 Xing Zheng
2016-05-30  7:32 ` Xing Zheng
2016-05-30 16:03   ` Mark Brown
2016-06-01 14:45 ` Rob Herring
2016-06-03 14:16   ` Xing Zheng [this message]
2016-06-06 23:50     ` Mark Brown
2016-06-07  2:49       ` Xing Zheng
2016-06-07 10:47         ` Mark Brown
2016-06-07 11:38           ` Xing Zheng
2016-06-07 12:06             ` Mark Brown
2016-06-07 12:47               ` Xing Zheng
2016-06-07 13:32                 ` Mark Brown
2016-06-07 13:48                   ` Xing Zheng
2016-06-07 14:54                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5751912C.6080904@rock-chips.com \
    --to=zhengxing@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).