From: David Daney <ddaney.cavm@gmail.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "David Daney" <ddaney@caviumnetworks.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Hou Zhiqiang" <B48286@freescale.com>,
"Liu Gang" <Gang.Liu@nxp.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Mingkai Hu" <Mingkai.Hu@freescale.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-samsung-soc@vger.kernel.org,
"Kukjin Kim" <kgene@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Ray Jui" <rjui@broadcom.com>,
"Tirumalesh Chalamarla" <tchalamarla@cavium.com>,
"Rob Herring" <robh+dt@kernel.org>, "Yuan Yao" <yao.yuan@nxp.com>,
"Wenbin Song" <Wenbin.Song@freescale.com>,
"Jan Glauber" <jglauber@cavium.com>,
"Gregory Clement" <gregory.clement@free-electrons.com>,
linux-amlogic@lists.infradead.org,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Rajesh Bhagat" <rajesh.bhagat@freescale.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Duc Dang" <dhdang@apm.com>,
linux-kernel@vger.kernel.org, "Carlo Caione" <carlo@caione.org>,
"Dinh Nguyen" <dinguyen@opensource.altera.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: Fix broken architected timer interrupt trigger
Date: Fri, 10 Jun 2016 09:50:08 -0700 [thread overview]
Message-ID: <575AEFC0.1070304@gmail.com> (raw)
In-Reply-To: <20160610082324.2a0967b0@arm.com>
On 06/10/2016 12:23 AM, Marc Zyngier wrote:
> On Thu, 09 Jun 2016 14:06:02 -0700
> David Daney <ddaney.cavm@gmail.com> wrote:
>
>> I spoke too soon...
>>
>> On 06/09/2016 11:11 AM, David Daney wrote:
>>> On 06/06/2016 10:56 AM, Marc Zyngier wrote:
>>>> The ARM architected timer specification mandates that the interrupt
>>>> associated with each timer is level triggered (which corresponds to
>>>> the "counter >= comparator" condition).
>>>>
>>>> A number of DTs are being remarkably creative, declaring the interrupt
>>>> to be edge triggered. A quick look at the TRM for the corresponding ARM
>>>> CPUs clearly shows that this is wrong, and I've corrected those.
>>>> For non-ARM designs (and in the absence of a publicly available TRM),
>>>> I've made them active low as well, which can't be completely wrong
>>>> as the GIC cannot disinguish between level low and level high.
>>>>
>>>> The respective maintainers are of course welcome to prove me wrong.
>>>>
>>>> While I was at it, I took the liberty to fix a couple of related issue,
>>>> such as some spurious affinity bits on ThunderX, and their complete
>>>> absence on ls1043a (both of which seem to be related to copy-pasting
>>>> from other DTs).
>>>>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>>> ---
>>>> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/apm/apm-storm.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/broadcom/ns2.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi | 8 ++++----
>>>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
>>>> 10 files changed, 40 insertions(+), 40 deletions(-)
>>>>
>>> [...]
>>>> diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
>>>> b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
>>>> index 2eb9b22..382d86f 100644
>>>> --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
>>>> +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
>>>> @@ -354,10 +354,10 @@
>>>>
>>>> timer {
>>>> compatible = "arm,armv8-timer";
>>>> - interrupts = <1 13 0xff01>,
>>>> - <1 14 0xff01>,
>>>> - <1 11 0xff01>,
>>>> - <1 10 0xff01>;
>>>> + interrupts = <1 13 8>,
>>>> + <1 14 8>,
>>>> + <1 11 8>,
>>>> + <1 10 8>;
>>
>>
>> NAK!
>>
>> According to arm,gic-v3.txt the trigger value must be either 1 or 4:
>>
>> The 3rd cell is the flags, encoded as follows:
>> bits[3:0] trigger type and level flags.
>> 1 = edge triggered
>> 4 = level triggered
>
> Which is a bug in the binding description. PPIs can be any trigger
> (just look at the TRM for CPUs that have devices connected to a PPI to
> be convinced - most of them are level low).
>
> This doesn't mean that you can distinguish level-high from level-low
> in a programmatic way. But the HW definitely can handle it.
>
> I'll update the GICv3 binding to reflect this.
>
> Now, coming back to your NAK: is level-low the right or wrong trigger
> for your implementation of the architected timers?
>
For the Cavium Thunder implementation of GIC-v3, there is no concept of
high and low. All we have is asserted and not-asserted, we have chosen
to map the concept of an asserted level-triggered source to
IRQ_TYPE_LEVEL_HIGH, and the transition from not-asserted to asserted on
an edge triggered source to IRQ_TYPE_EDGE_RISING.
Looking and the code and specifications, I don't see in irq-gic-v3.c or
PRD03-GENC-010745-35 any indication that the concepts of "high" and
"low" exist either, although I certainly could have missed something.
David Daney
next prev parent reply other threads:[~2016-06-10 16:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 17:56 [PATCH v3 0/2] arm/arm64: Fix architected timer interrupt trigger Marc Zyngier
2016-06-06 17:56 ` [PATCH v3 1/2] clocksource/arm_arch_timer: Force per-CPU interrupt to be level-triggered Marc Zyngier
2016-06-09 21:10 ` David Daney
2016-06-10 7:29 ` Marc Zyngier
2016-06-10 17:39 ` David Daney
2016-06-11 9:41 ` Marc Zyngier
[not found] ` <CANe6Qb_sx8_rRHZG1PR=A+cgxqYTzreZ0rD01X-gtEDb=h1cVQ@mail.gmail.com>
2016-06-12 10:12 ` Marc Zyngier
2016-06-10 21:51 ` Duc Dang
2016-06-06 17:56 ` [PATCH v3 2/2] arm64: dts: Fix broken architected timer interrupt trigger Marc Zyngier
2016-06-07 7:08 ` Krzysztof Kozlowski
2016-06-07 7:19 ` Michal Simek
2016-06-09 15:05 ` Dinh Nguyen
2016-06-09 15:23 ` Carlo Caione
2016-06-09 18:11 ` David Daney
2016-06-09 21:06 ` David Daney
2016-06-10 7:23 ` Marc Zyngier
2016-06-10 16:50 ` David Daney [this message]
2016-06-10 16:56 ` Marc Zyngier
2016-06-10 17:32 ` David Daney
2016-06-11 10:04 ` Marc Zyngier
2016-06-10 21:48 ` Duc Dang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575AEFC0.1070304@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=B48286@freescale.com \
--cc=Gang.Liu@nxp.com \
--cc=Mingkai.Hu@freescale.com \
--cc=Wenbin.Song@freescale.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=carlo@caione.org \
--cc=daniel.lezcano@linaro.org \
--cc=ddaney@caviumnetworks.com \
--cc=dhdang@apm.com \
--cc=dinguyen@opensource.altera.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jglauber@cavium.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=rajesh.bhagat@freescale.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soren.brinkmann@xilinx.com \
--cc=tchalamarla@cavium.com \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
--cc=yao.yuan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).