From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>,
abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue in s626.c
Date: Sat, 18 Jun 2016 15:21:17 +0100 [thread overview]
Message-ID: <576558DD.7060805@osg.samsung.com> (raw)
In-Reply-To: <20160618035122.GA1308@kroah.com>
On 18/06/16 04:51, Greg KH wrote:
> On Mon, May 30, 2016 at 03:21:27PM +0100, Luis de Bethencourt wrote:
>> On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
>>> This is a patch to the s626.c file that fixes up a line over 80
>>> characters issues found by the checkpatch.pl tool.
>>>
>>> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
>>
>> Looks good :)
>>
>> This is the only instance of the line over 80 characters Warning in that file.
>>
>> Like previous patches, no need to mention the file being fixed in the commit
>> message. It isn't a big deal though.
>>
>> +1
>
> Not much I can do with at "+1", please respond with a:
> Acked-by:
> or even better:
> Reviewed-by:
>
> with the proper info, so I can add it to the patch and give you credit
> for reviewing it.
>
> thanks,
>
> greg k-h
>
Reviewed-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Sorry, sometimes I am not sure if my comments warrant an Acked-by/Reviewed-by.
Will always add one from now on.
Thanks :)
Luis
next prev parent reply other threads:[~2016-06-18 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 5:26 [PATCH v2 1/4] staging : comedi : fix type issues in s626.c Ravishankar Karkala Mallikarjunayya
2016-05-28 5:26 ` [PATCH v2 2/4] Staging: comedi: Fix WARNING issue " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:11 ` Luis de Bethencourt
2016-05-31 10:30 ` Ian Abbott
2016-05-28 5:26 ` [PATCH v2 3/4] Staging: comedi:Fix unsigned int to bare use of unsigned " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:15 ` Luis de Bethencourt
2016-05-31 10:31 ` Ian Abbott
2016-05-28 5:26 ` [PATCH v2 4/4] Staging: comedi: fix line over 80 characters " Ravishankar Karkala Mallikarjunayya
2016-05-30 14:21 ` Luis de Bethencourt
2016-06-18 3:51 ` Greg KH
2016-06-18 14:21 ` Luis de Bethencourt [this message]
2016-05-31 10:31 ` Ian Abbott
2016-05-30 14:01 ` [PATCH v2 1/4] staging : comedi : fix type issues " Luis de Bethencourt
2016-05-31 10:29 ` Ian Abbott
2016-05-31 17:07 ` Joe Perches
2016-06-01 9:28 ` Ian Abbott
2016-06-18 3:53 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-05-20 6:22 [PATCH v2 4/4] Staging: comedi: fix line over 80 characters issue " Ravishankar Karkala Mallikarjunayya
2016-05-20 10:15 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576558DD.7060805@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).