From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Andy Gross <andy.gross@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v8 05/10] media: venus: adding core part and helper functions
Date: Tue, 2 May 2017 12:17:20 +0300 [thread overview]
Message-ID: <5840407a-8812-65a9-5716-f3a64427649b@linaro.org> (raw)
In-Reply-To: <20170429202247.GV15143@minitux>
Hi,
On 04/29/2017 11:22 PM, Bjorn Andersson wrote:
> On Fri 28 Apr 15:02 PDT 2017, Jordan Crouse wrote:
>
>> On Fri, Apr 28, 2017 at 12:13:52PM +0300, Stanimir Varbanov wrote:
>>> +int venus_boot(struct device *parent, struct device *fw_dev)
>>> +{
>>> + const struct firmware *mdt;
>>> + phys_addr_t mem_phys;
>>> + ssize_t fw_size;
>>> + size_t mem_size;
>>> + void *mem_va;
>>> + int ret;
>>> +
>>> + if (!qcom_scm_is_available())
>>> + return -EPROBE_DEFER;
>>> +
>>> + fw_dev->parent = parent;
>>> + fw_dev->release = device_release_dummy;
>>> +
>>> + ret = dev_set_name(fw_dev, "%s:%s", dev_name(parent), "firmware");
>>> + if (ret)
>>> + return ret;
>>> +
>>> + ret = device_register(fw_dev);
>>> + if (ret < 0)
>>> + return ret;
>>> +
>>> + ret = of_reserved_mem_device_init_by_idx(fw_dev, parent->of_node, 0);
>>> + if (ret)
>>> + goto err_unreg_device;
>>> +
>>> + mem_size = VENUS_FW_MEM_SIZE;
>>> +
>>> + mem_va = dmam_alloc_coherent(fw_dev, mem_size, &mem_phys, GFP_KERNEL);
>>> + if (!mem_va) {
>>> + ret = -ENOMEM;
>>> + goto err_unreg_device;
>>> + }
>>> +
>>> + ret = request_firmware(&mdt, VENUS_FIRMWARE_NAME, fw_dev);
>>> + if (ret < 0)
>>> + goto err_unreg_device;
>>> +
>>> + fw_size = qcom_mdt_get_size(mdt);
>>> + if (fw_size < 0) {
>>> + ret = fw_size;
>>> + release_firmware(mdt);
>>> + goto err_unreg_device;
>>> + }
>>> +
>>> + ret = qcom_mdt_load(fw_dev, mdt, VENUS_FIRMWARE_NAME, VENUS_PAS_ID,
>>> + mem_va, mem_phys, mem_size);
>>> +
>>> + release_firmware(mdt);
>>> +
>>> + if (ret)
>>> + goto err_unreg_device;
>>> +
>>> + ret = qcom_scm_pas_auth_and_reset(VENUS_PAS_ID);
>>> + if (ret)
>>> + goto err_unreg_device;
>>> +
>>> + return 0;
>>> +
>>> +err_unreg_device:
>>> + device_unregister(fw_dev);
>>> + return ret;
>>> +}
>>
>> Hey, this looks familiar - almost line for line identical to what we'll need to
>> do for GPU.
>>
>> Bjorn - Is this enough to qualify for generic status in the mdt_loader code?
>> I know its just two consumers, but it would save 50 or 60 lines of code between
>> the two drivers and be easier to maintain.
>>
>
> I think the code setting up the struct device for memory allocation
> should be done during probe of the parent, so that I don't think should
> be shared.
>
> The part that allocates memory from a device, loads the mdt into that
> memory and calls auth_and_reset() sounds like a useful thing to move to
> the mdt_loader.c
I agree, who is going to do that?
--
regards,
Stan
next prev parent reply other threads:[~2017-05-02 9:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 9:13 [PATCH v8 00/10] Qualcomm video decoder/encoder driver Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 01/10] firmware: qcom_scm: Fix to allow COMPILE_TEST-ing Stanimir Varbanov
2017-05-02 19:22 ` Bjorn Andersson
2017-05-05 11:34 ` Hans Verkuil
2017-05-05 13:23 ` Stanimir Varbanov
2017-05-05 14:30 ` Hans Verkuil
2017-04-28 9:13 ` [PATCH v8 02/10] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management Stanimir Varbanov
2017-05-05 11:36 ` Hans Verkuil
2017-04-28 9:13 ` [PATCH v8 03/10] doc: DT: venus: binding document for Qualcomm video driver Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 04/10] MAINTAINERS: Add Qualcomm Venus video accelerator driver Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 05/10] media: venus: adding core part and helper functions Stanimir Varbanov
2017-04-28 22:02 ` Jordan Crouse
2017-04-29 20:22 ` Bjorn Andersson
2017-05-02 9:17 ` Stanimir Varbanov [this message]
2017-05-03 13:46 ` Jordan Crouse
2017-04-29 22:21 ` Sakari Ailus
2017-05-02 8:52 ` Stanimir Varbanov
2017-05-02 18:52 ` Bjorn Andersson
2017-05-05 13:29 ` Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 06/10] media: venus: vdec: add video decoder files Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 07/10] media: venus: venc: add video encoder files Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 08/10] media: venus: hfi: add Host Firmware Interface (HFI) Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 09/10] media: venus: hfi: add Venus HFI files Stanimir Varbanov
2017-04-28 9:13 ` [PATCH v8 10/10] media: venus: enable building of Venus video driver Stanimir Varbanov
2017-05-05 12:44 ` [PATCH v8 00/10] Qualcomm video decoder/encoder driver Hans Verkuil
2017-05-05 13:42 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5840407a-8812-65a9-5716-f3a64427649b@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).