linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Clark <James.Clark@arm.com>
To: Tan Xiaojun <tanxiaojun@huawei.com>,
	Jeremy Linton <Jeremy.Linton@arm.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"alexander.shishkin@linux.intel.com" 
	<alexander.shishkin@linux.intel.com>,
	"jolsa@redhat.com" <jolsa@redhat.com>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"yao.jin@linux.intel.com" <yao.jin@linux.intel.com>,
	"tmricht@linux.ibm.com" <tmricht@linux.ibm.com>,
	"brueckner@linux.ibm.com" <brueckner@linux.ibm.com>,
	"songliubraving@fb.com" <songliubraving@fb.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	Kim Phillips <Kim.Phillips@amd.com>
Cc: "gengdongjiu@huawei.com" <gengdongjiu@huawei.com>,
	"wxf.wang@hisilicon.com" <wxf.wang@hisilicon.com>,
	"liwei391@huawei.com" <liwei391@huawei.com>,
	"huawei.libin@huawei.com" <huawei.libin@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>, Al Grant <Al.Grant@arm.com>,
	nd <nd@arm.com>
Subject: Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events
Date: Wed, 16 Oct 2019 10:12:43 +0000	[thread overview]
Message-ID: <58bed363-41ee-e425-a36e-e3c69d1a4e90@arm.com> (raw)
In-Reply-To: <335fedb8-128c-7d34-c5e8-15cd660fe12e@huawei.com>

Hi Xiaojun,

>>
>> What do you mean when the user specifies "event:pp", if the SPE is available, configure and record the spe data directly via the perf event open syscall?
>> (perf.data itself is the same as using -e arm_spe_0//xxx?)
> 
> I mean, for the perf record, if the user does not add ":pp" to these events, the original process is taken, and if ":pp" is added, the spe process is taken.
> 

Yes we think this is the best way to do it considering that SPE has been implemented as a separate PMU and it will be very difficult to do it in the Kernel when the precise_ip attribute is set.

I think doing everything in userspace is easiest. This will at least mean that users of Perf don't have to be aware of the details of SPE to get precise sample data.

So if the user specifies "event:p" when SPE is available, the SPE PMU is automatically configured data is recorded. If the user also specifies -e arm_spe_0//xxx and wants to do some manual configuration, then that could override the automatic configuration.


James


  reply	other threads:[~2019-10-16 10:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02  9:40 [RFC PATCH 0/3] perf tools: Add support for "report" for some spe events Tan Xiaojun
2019-08-02  9:40 ` [RFC PATCH 1/3] perf tools: Move arm-spe-pkt-decoder.h/c to the new dir Tan Xiaojun
2019-08-02  9:40 ` [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events Tan Xiaojun
2019-08-08 21:00   ` Jeremy Linton
2019-08-09  6:12     ` Tan Xiaojun
2019-10-04 13:46       ` James Clark
2019-10-08  5:59         ` Tan Xiaojun
2019-10-09  9:48           ` James Clark
2019-10-09 11:09             ` Tan Xiaojun
2019-10-09 11:49               ` Tan Xiaojun
2019-10-16 10:12                 ` James Clark [this message]
2019-10-17  1:51                   ` Tan Xiaojun
2019-10-17  6:08                     ` Tan Xiaojun
2019-10-09  2:43         ` Tan Xiaojun
2019-10-09  3:06         ` Tan Xiaojun
2019-08-02  9:40 ` [RFC PATCH 3/3] perf report: add --spe options for arm-spe Tan Xiaojun
2019-08-21 12:38   ` James Clark
2019-08-22  1:44     ` Tan Xiaojun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58bed363-41ee-e425-a36e-e3c69d1a4e90@arm.com \
    --to=james.clark@arm.com \
    --cc=Al.Grant@arm.com \
    --cc=Jeremy.Linton@arm.com \
    --cc=Kim.Phillips@amd.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=brueckner@linux.ibm.com \
    --cc=gengdongjiu@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=huawei.libin@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=nd@arm.com \
    --cc=peterz@infradead.org \
    --cc=songliubraving@fb.com \
    --cc=tanxiaojun@huawei.com \
    --cc=tmricht@linux.ibm.com \
    --cc=wxf.wang@hisilicon.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).