linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>, Stuart Yoder <stuyoder@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	gregkh <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
	Razvan Stefanescu <razvan.stefanescu@nxp.com>,
	Roy Pledge <roy.pledge@nxp.com>,
	Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support
Date: Thu, 5 Apr 2018 10:30:01 +0000	[thread overview]
Message-ID: <5AC5FAA8.80409@nxp.com> (raw)
In-Reply-To: <20180404124246.GA20869@lunn.ch>

Hello,

My 2c below.

On 04/04/2018 03:42 PM, Andrew Lunn wrote:
>> I hear you.  It is more complicated this way...having all these individual
>> objects vs just a single "bundle" of them that represents a NIC.  But, that's
>> the way the DPAA2 hardware is, and we're implementing kernel support for
>> the hardware as it is.
>
> Hi Stuart
>
> I see we are not making any progress here.
>
> So what i suggest is you post the kernel code and configuration tool
> concept to netdev for a full review. You want reviews from David
> Miller, Jiri Pirko, Jakub Kicinski, David Ahern, etc.
>

I think that the discussion steered too much towards networking related 
topics, while this ioctl doesn't have much to do with networking.
It's just an ioctl for our mc-bus bus driver that is used to manage the 
devices on this bus through userspace tools.
In addition, I'd drop any mention of our reference user space app 
(restool) to emphasize that this ioctl is not added just for a 
particular user space app. I think Stuart also mentioned this.

---
Thanks & Best Regards, Laurentiu

  parent reply	other threads:[~2018-04-05 10:30 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23 15:38 [PATCH v3 0/4] bus: fsl-mc: enhance Management Complex userspace support Ioana Ciornei
2018-03-23 15:38 ` [PATCH v3 1/4] bus: fsl-mc: move fsl_mc_command struct in a uapi header Ioana Ciornei
2018-03-24 20:12   ` kbuild test robot
2018-03-23 15:38 ` [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Ioana Ciornei
2018-03-23 15:46   ` Greg KH
2018-03-23 15:56     ` Ioana Ciornei
2018-03-23 16:09       ` Greg KH
2018-03-23 20:13         ` Ioana Ciornei
2018-03-24  7:51   ` Arnd Bergmann
2018-03-28 14:27     ` Ioana Ciornei
2018-03-28 15:43       ` Arnd Bergmann
2018-03-28 16:28         ` Andrew Lunn
2018-04-02 13:24           ` Ioana Ciornei
2018-04-02 13:44             ` Andrew Lunn
2018-04-03 11:12               ` Razvan Stefanescu
2018-04-03 13:04                 ` Andrew Lunn
2018-04-03 23:57         ` Stuart Yoder
2018-04-04  1:05           ` Andrew Lunn
2018-04-04  3:22             ` Stuart Yoder
2018-04-04 12:42               ` Andrew Lunn
2018-04-05  4:24                 ` Stuart Yoder
2018-04-05 10:30                 ` Laurentiu Tudor [this message]
2018-04-05 11:47                   ` Andrew Lunn
2018-04-05 12:16                     ` Laurentiu Tudor
2018-04-05 12:48                       ` Andrew Lunn
2018-04-05 14:43                         ` Laurentiu Tudor
2018-04-05 15:23                           ` Andrew Lunn
2018-04-05 15:35                             ` Ruxandra Ioana Ciocoi Radulescu
2018-04-05 16:12                               ` gregkh
2018-04-05 16:56                                 ` Andrew Lunn
2018-04-05 12:30                   ` gregkh
2018-04-05 14:09                     ` Laurentiu Tudor
2018-04-05 14:19                       ` gregkh
2018-03-23 15:38 ` [PATCH v3 3/4] bus: fsl-mc: add root dprc rescan attribute Ioana Ciornei
2018-03-23 15:48   ` Greg KH
2018-03-23 16:00     ` Ioana Ciornei
2018-03-23 15:38 ` [PATCH v3 4/4] bus: fsl-mc: add bus " Ioana Ciornei
2018-03-23 15:49   ` Greg KH
2018-04-02 13:46     ` Ioana Ciornei
2018-04-03  7:04       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AC5FAA8.80409@nxp.com \
    --to=laurentiu.tudor@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=razvan.stefanescu@nxp.com \
    --cc=roy.pledge@nxp.com \
    --cc=ruxandra.radulescu@nxp.com \
    --cc=stuyoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).