From: zhong jiang <zhongjiang@huawei.com>
To: Bhaskar Singh <bhaskar.kernel@gmail.com>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: rtl8188eu: Type cast function argument
Date: Sat, 18 Aug 2018 22:33:31 +0800 [thread overview]
Message-ID: <5B782E3B.7030001@huawei.com> (raw)
In-Reply-To: <20180818142409.GA17122@Gentoo-PC>
On 2018/8/18 22:24, Bhaskar Singh wrote:
> This patch might suppress some warrning.
>
> The function prototype of rtw_malloc2d is
>
> void *rtw_malloc2d(int h, int w, int size)
>
> This patch also resolves the checkpatch.pl warning
>
> WARNING: line over 80 characters
>
> Signed-off-by: Bhaskar Singh <bhaskar.kernel@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_efuse.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> index 0fd306a808c4..735d654b2844 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> @@ -91,7 +91,8 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8 *pbuf)
> if (!efuseTbl)
> return;
>
> - eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E, EFUSE_MAX_WORD_UNIT, sizeof(u16));
> + eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E,
> + EFUSE_MAX_WORD_UNIT, (int)sizeof(u16));
>
You should be align with left parenthesis.
Thanks,
zhong jiang
> if (!eFuseWord) {
> DBG_88E("%s: alloc eFuseWord fail!\n", __func__);
> goto eFuseWord_failed;
next prev parent reply other threads:[~2018-08-18 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 14:24 [PATCH] staging: rtl8188eu: Type cast function argument Bhaskar Singh
2018-08-18 14:33 ` zhong jiang [this message]
2018-08-18 14:58 ` Bhaskar Singh
2018-08-18 15:07 ` Joe Perches
2018-08-20 9:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B782E3B.7030001@huawei.com \
--to=zhongjiang@huawei.com \
--cc=bhaskar.kernel@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).