From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751468AbcKGT1q convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Mon, 7 Nov 2016 14:27:46 -0500
Received: from mga07.intel.com ([134.134.136.100]:35277 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751100AbcKGT1n (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Nov 2016 14:27:43 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,459,1473145200"; 
   d="scan'208";a="1081866424"
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Christoph Hellwig <hch@lst.de>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "James Bottomley" <James.Bottomley@HansenPartnership.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        Andy Lutomirski <luto@kernel.org>, Arve Hj?nnev?g <arve@android.com>,
        "Michael Ryleev" <gmar@google.com>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Yaniv Gardi <ygardi@codeaurora.org>,
        Avri Altman <avri.altman@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "Usyskin, Alexander" <alexander.usyskin@intel.com>
Subject: RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem
Thread-Topic: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem
Thread-Index: AQHSOSjV53ZeniQD5UKbC3Ck9d4uNqDNvsCAgAAj9PA=
Date: Mon, 7 Nov 2016 19:27:38 +0000
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B5431750E@hasmsx108.ger.corp.intel.com>
References: <1478548394-8184-1-git-send-email-tomas.winkler@intel.com>
 <1478548394-8184-10-git-send-email-tomas.winkler@intel.com>
 <20161107190109.GA5110@lst.de>
In-Reply-To: <20161107190109.GA5110@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDkwMWJiNDEtMmQxMC00ODc1LWFiMmItYzgzZmM0NzUzNTVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkIxYlwvOTRzRXFiMk95ancydzYzYmI5N0xMeHN6Q1U4Ym9LbWlQb1RTSmFzPSJ9
x-originating-ip: [10.184.70.10]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 
> On Mon, Nov 07, 2016 at 09:53:12PM +0200, Tomas Winkler wrote:
> > Register UFS RPMB LUN with the RPMB subsystem and provide
> > implementation for the RPMB access operations. RPMB partition is
> > accessed via a sequence of security protocol in and security protocol
> > out commands with UFS specific parameters. This multi step process is
> > abstracted into 4 basic RPMB commands.
> 
> This is a giant layering violation - the security protocol is not something up to
> the LLDD but the core code.
> 
> And honestly the idea of defintining a security protocol in the UFS spec is just
> as braindead.  If you care about this please take it up with T10 to get RPMB
> support into one of the core SCSI specs instead of a transport.

I  value your opinion but I'm not responsible for inventing RPMB 
and/or its  implementation storage devices (eMMC, UFC, NVMe), it's pretty much done deal out there in the wild. 
I'm just trying to provide common API above it.

Thanks
Tomas