From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"James Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Arve Hj?nnev?g <arve@android.com>,
"Michael Ryleev" <gmar@google.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Yaniv Gardi <ygardi@codeaurora.org>,
Avri Altman <avri.altman@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>
Subject: RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem
Date: Wed, 22 Mar 2017 21:25:36 +0000 [thread overview]
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B543C0457@hasmsx108.ger.corp.intel.com> (raw)
In-Reply-To: <20161107213754.GA10433@lst.de>
>
> On Mon, Nov 07, 2016 at 07:27:38PM +0000, Winkler, Tomas wrote:
> > I value your opinion but I'm not responsible for inventing RPMB
> > and/or its implementation storage devices (eMMC, UFC, NVMe), it's pretty
> much done deal out there in the wild.
> > I'm just trying to provide common API above it.
Somehow I've missed that answer, now I got back when search for comments before I'll post a new series.
> And the common API must go through the SCSI midlayer.
I've actually tried to do a midlayer, but I found it's too UFS specific, so there is no point to this abstraction.
As not all needed data are accessible via scsi calls. The solution I propose fits with what is done in eMMC (emmc specific IOCTL).
There is already some code that breaks that layering in ufshcd_set_dev_pwr_mode when talking to the special sdev_ufs.
Maybe I need more hint for the correct directions.
If it can't we won't
> support it, so please drop the UFS patches from the series.
If you have more constructive comments, I'll be glad to hear and address.
Thanks
Tomas
next prev parent reply other threads:[~2017-03-22 21:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 19:53 [PATCH v7 00/11] char:rpmb: Replay Protected Memory Block (RPMB) subsystem Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 01/11] rpmb: add " Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 02/11] rpmb: enable emmc specific read data fixup Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 03/11] rpmb: add sysfs-class ABI documentation Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 04/11] char: rpmb: add device attributes Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 05/11] char: rpmb: provide a user space interface Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 06/11] char: rpmb: add RPMB simulation device Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 07/11] tools rpmb: add RPBM access tool Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 08/11] mmc: block: register RPMB partition with the RPMB subsystem Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 09/11] scsi: ufs: connect to " Tomas Winkler
2016-11-07 19:01 ` Christoph Hellwig
2016-11-07 19:27 ` Winkler, Tomas
2016-11-07 21:37 ` Christoph Hellwig
2017-03-22 21:25 ` Winkler, Tomas [this message]
2016-11-07 19:53 ` [PATCH v7 10/11] scsi: ufs: retrieve rpmb rw size Tomas Winkler
2016-11-07 19:53 ` [PATCH v7 11/11] char: rpmb: Document Replay Protected Memory Block (RPMB) subsystem Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B543C0457@hasmsx108.ger.corp.intel.com \
--to=tomas.winkler@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Joao.Pinto@synopsys.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=arve@android.com \
--cc=avri.altman@gmail.com \
--cc=gmar@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ulf.hansson@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).