From: Chanwoo Choi <cw00.choi@samsung.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Roger Quadros <rogerq@ti.com>,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
linux-omap@vger.kernel.org, Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v1 2/5] extcon: Return -EPROBE_DEFER when extcon device is not found
Date: Wed, 14 Nov 2018 08:52:35 +0900 [thread overview]
Message-ID: <5BEB63C3.1020504@samsung.com> (raw)
In-Reply-To: <5BE8C821.5080002@samsung.com>
Hi Andy,
I was thinking about again to change from NULL to EPROBE_DEFER.
extcon_get_extcon_dev() function was almost called in the probe function.
But, this function might be called on other position instead of probe.
ENODEV is more correct error instead of EPROBE_DEFER.
Sorry. I'll withdraw my opinion related acked-by tag until we are clarifying it.
On 2018년 11월 12일 09:24, Chanwoo Choi wrote:
> Hi Andy,
>
> On 2018년 11월 11일 03:10, Andy Shevchenko wrote:
>> All current users of extcon_get_extcon_dev() API considers
>> an extcon device a mandatory to appear. Thus, they all convert
>> NULL pointer to -EPROBE_DEFER error code.
>>
>> There is one more caller anticipated with the same requirements.
>>
>> To decrease a code duplication and a burden to the callers,
>> return -EPROBE_DEFER directly from extcon_get_extcon_dev().
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/extcon/extcon-axp288.c | 4 ++--
>> drivers/extcon/extcon.c | 2 +-
>> drivers/power/supply/axp288_charger.c | 8 ++++----
>> drivers/usb/phy/phy-omap-otg.c | 6 +++---
>> drivers/usb/typec/tcpm/fusb302.c | 4 ++--
>> 5 files changed, 12 insertions(+), 12 deletions(-)
>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Best Regards,
> Chanwoo Choi
>
>>
>> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
>> index a983708b77a6..3472d3b756ed 100644
>> --- a/drivers/extcon/extcon-axp288.c
>> +++ b/drivers/extcon/extcon-axp288.c
>> @@ -360,8 +360,8 @@ static int axp288_extcon_probe(struct platform_device *pdev)
>> name = acpi_dev_get_first_match_name("INT3496", NULL, -1);
>> if (name) {
>> info->id_extcon = extcon_get_extcon_dev(name);
>> - if (!info->id_extcon)
>> - return -EPROBE_DEFER;
>> + if (IS_ERR(info->id_extcon))
>> + return PTR_ERR(info->id_extcon);
>>
>> dev_info(dev, "controlling USB role\n");
>> } else {
>> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
>> index 5ab0498be652..2bd0f2f33f05 100644
>> --- a/drivers/extcon/extcon.c
>> +++ b/drivers/extcon/extcon.c
>> @@ -884,7 +884,7 @@ struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name)
>> if (!strcmp(sd->name, extcon_name))
>> goto out;
>> }
>> - sd = NULL;
>> + sd = ERR_PTR(-EPROBE_DEFER);
(snip)
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2018-11-13 23:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 18:10 [PATCH v1 1/5] drivercore: Revert "deferral race condition fix" Andy Shevchenko
2018-11-10 18:10 ` [PATCH v1 2/5] extcon: Return -EPROBE_DEFER when extcon device is not found Andy Shevchenko
2018-11-10 18:39 ` Guenter Roeck
2018-11-11 0:06 ` Sebastian Reichel
2018-11-12 0:24 ` Chanwoo Choi
2018-11-13 23:52 ` Chanwoo Choi [this message]
2018-11-14 8:35 ` Andy Shevchenko
2018-11-14 9:13 ` Chanwoo Choi
2018-11-14 9:36 ` Andy Shevchenko
2018-11-14 9:48 ` Chanwoo Choi
2018-11-14 10:20 ` Andy Shevchenko
2018-11-14 11:05 ` Chanwoo Choi
2018-11-14 11:17 ` Andy Shevchenko
2018-11-14 14:04 ` Andy Shevchenko
2018-11-15 1:16 ` Chanwoo Choi
2018-11-12 11:47 ` Heikki Krogerus
2018-11-10 18:10 ` [PATCH v1 3/5] staging: typec: fusb302: Rename fcs,extcon-name to linux,extcon-name Andy Shevchenko
2018-11-10 18:40 ` Guenter Roeck
2018-11-10 18:11 ` [PATCH v1 4/5] usb: dwc3: drd: Switch to device property for 'extcon' handling Andy Shevchenko
2018-11-12 11:47 ` Felipe Balbi
2018-11-10 18:11 ` [PATCH v1 5/5] usb: dwc3: drd: Add support for DR detection through extcon Andy Shevchenko
2018-11-10 18:26 ` [PATCH v1 1/5] drivercore: Revert "deferral race condition fix" Greg Kroah-Hartman
2018-11-10 18:36 ` Andy Shevchenko
2018-11-11 11:45 ` Hans de Goede
2018-11-11 13:04 ` Andy Shevchenko
2018-11-11 19:26 ` Rob Herring
2018-11-11 23:53 ` Andy Shevchenko
2018-11-14 23:25 ` Grant Likely
2018-11-12 16:11 ` Peter Ujfalusi
2018-11-14 0:33 ` Mark Brown
2018-11-14 8:45 ` Andy Shevchenko
2018-11-14 10:19 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BEB63C3.1020504@samsung.com \
--to=cw00.choi@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).