From: "Markus F.X.J. Oberhumer" <markus@oberhumer.com>
To: Dave Rodgman <dave.rodgman@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
Matt Sealey <Matt.Sealey@arm.com>,
"nitingupta910@gmail.com" <nitingupta910@gmail.com>,
"minchan@kernel.org" <minchan@kernel.org>,
"sergey.senozhatsky.work@gmail.com"
<sergey.senozhatsky.work@gmail.com>,
"sonnyrao@google.com" <sonnyrao@google.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
nd <nd@arm.com>, "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [PATCH 4/8] lib/lzo: 64-bit CTZ on arm64
Date: Thu, 6 Dec 2018 16:52:57 +0100 [thread overview]
Message-ID: <5C0945D9.3030500@oberhumer.com> (raw)
In-Reply-To: <20181130142600.13782-5-dave.rodgman@arm.com>
Acked-by: Markus F.X.J. Oberhumer <markus@oberhumer.com>
On 2018-11-30 15:26, Dave Rodgman wrote:
> From: Matt Sealey <matt.sealey@arm.com>
>
> LZO leaves some performance on the table by not realising that arm64 can
> optimize count-trailing-zeros bit operations.
>
> Add CONFIG_ARM64 to the checked definitions alongside CONFIG_X86_64 to
> enable the use of rbit/clz instructions on full 64-bit quantities.
>
> Link: http://lkml.kernel.org/r/20181127161913.23863-5-dave.rodgman@arm.com
> Signed-off-by: Matt Sealey <matt.sealey@arm.com>
> Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Markus F.X.J. Oberhumer <markus@oberhumer.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <nitingupta910@gmail.com>
> Cc: Richard Purdie <rpurdie@openedhand.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> Cc: Sonny Rao <sonnyrao@google.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> lib/lzo/lzodefs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/lzo/lzodefs.h b/lib/lzo/lzodefs.h
> index c0193f726db0..c8965dc181df 100644
> --- a/lib/lzo/lzodefs.h
> +++ b/lib/lzo/lzodefs.h
> @@ -28,7 +28,7 @@
>
> #if defined(__BIG_ENDIAN) && defined(__LITTLE_ENDIAN)
> #error "conflicting endian definitions"
> -#elif defined(CONFIG_X86_64)
> +#elif defined(CONFIG_X86_64) || defined(CONFIG_ARM64)
> #define LZO_USE_CTZ64 1
> #define LZO_USE_CTZ32 1
> #elif defined(CONFIG_X86) || defined(CONFIG_PPC)
>
--
Markus Oberhumer, <markus@oberhumer.com>, http://www.oberhumer.com/
next prev parent reply other threads:[~2018-12-06 15:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 14:26 [PATCH v4 0/7] lib/lzo: performance improvements Dave Rodgman
2018-11-30 14:26 ` [PATCH 1/8] lib/lzo: tidy-up ifdefs Dave Rodgman
2018-12-06 15:49 ` Markus F.X.J. Oberhumer
2018-11-30 14:26 ` [PATCH 2/8] lib/lzo: clean-up by introducing COPY16 Dave Rodgman
2018-12-06 15:56 ` Markus F.X.J. Oberhumer
2018-11-30 14:26 ` [PATCH 3/8] lib/lzo: enable 64-bit CTZ on Arm Dave Rodgman
2018-12-06 15:51 ` Markus F.X.J. Oberhumer
2018-11-30 14:26 ` [PATCH 4/8] lib/lzo: 64-bit CTZ on arm64 Dave Rodgman
2018-12-06 15:52 ` Markus F.X.J. Oberhumer [this message]
2018-11-30 14:26 ` [PATCH 5/8] lib/lzo: fast 8-byte copy " Dave Rodgman
2018-12-06 15:53 ` Markus F.X.J. Oberhumer
2018-11-30 14:26 ` [PATCH 6/8] lib/lzo: implement run-length encoding Dave Rodgman
2018-12-06 15:56 ` Markus F.X.J. Oberhumer
2018-11-30 14:26 ` [PATCH 7/8] lib/lzo: separate lzo-rle from lzo Dave Rodgman
2018-12-01 8:48 ` Herbert Xu
2018-11-30 14:26 ` [PATCH 8/8] zram: default to lzo-rle instead of lzo Dave Rodgman
2018-12-05 7:30 ` [PATCH v4 0/7] lib/lzo: performance improvements Sergey Senozhatsky
2018-12-05 9:50 ` Dave Rodgman
2018-12-05 10:20 ` Sergey Senozhatsky
2018-12-06 15:47 ` Markus F.X.J. Oberhumer
2018-12-06 16:22 ` Matt Sealey
2018-12-07 15:54 ` Dave Rodgman
2019-01-07 15:35 ` Dave Rodgman
-- strict thread matches above, loose matches on Subject: below --
2018-11-30 11:47 [PATCH v3 " Dave Rodgman
2018-11-30 11:47 ` [PATCH 4/8] lib/lzo: 64-bit CTZ on arm64 Dave Rodgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C0945D9.3030500@oberhumer.com \
--to=markus@oberhumer.com \
--cc=Matt.Sealey@arm.com \
--cc=akpm@linux-foundation.org \
--cc=dave.rodgman@arm.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=nd@arm.com \
--cc=nitingupta910@gmail.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=sonnyrao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).