linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	tglx@linutronix.de, jason@lakedaemon.net, sboyd@kernel.org,
	mturquette@baylibre.com, mark.rutland@arm.com,
	robh+dt@kernel.org, daniel.lezcano@linaro.org,
	paul@crapouillou.net, sernia.zhou@foxmail.com,
	zhenwenjin@gmail.com, dongsheng.qiu@ingenic.com
Subject: Re: [PATCH 4/4] irqchip: Ingenic: Add support for TCU of X1000.
Date: Wed, 4 Mar 2020 19:22:30 +0800	[thread overview]
Message-ID: <5E5F8F76.6060803@wanyeetech.com> (raw)
In-Reply-To: <cf9434a075ee7efa6430bc39877c416c@kernel.org>

Hi Marc,

On 2020年03月04日 18:58, Marc Zyngier wrote:
> On 2020-02-19 08:29, 周琰杰 wrote:
>> X1000 has a different TCU containing OST, since X1000, OST has been
>> independent of TCU. This patch is prepare for later OST driver.
>
> You keep on talking about OST (whatever that is), but never deals with 
> it.

Sorry, I didn't make it clear. My intention was to explain why we need 
to add an IRQCHIP_DECLARE to x1000 separately.

> Why don't you just say
>
> "Enable TCU support for Ingenic X1000, which can be supported by
> the existing driver."
>
> as this is what the patch is doing?

Yes, this patch is to ensure that TCU can be used normally when the new 
OST driver is merged, thank you for your suggestion.

Thanks and best regards!

>
>>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> ---
>>  drivers/irqchip/irq-ingenic-tcu.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/irq-ingenic-tcu.c
>> b/drivers/irqchip/irq-ingenic-tcu.c
>> index 6d05cef..7a7222d 100644
>> --- a/drivers/irqchip/irq-ingenic-tcu.c
>> +++ b/drivers/irqchip/irq-ingenic-tcu.c
>> @@ -180,3 +180,4 @@ static int __init ingenic_tcu_irq_init(struct
>> device_node *np,
>>  IRQCHIP_DECLARE(jz4740_tcu_irq, "ingenic,jz4740-tcu", 
>> ingenic_tcu_irq_init);
>>  IRQCHIP_DECLARE(jz4725b_tcu_irq, "ingenic,jz4725b-tcu", 
>> ingenic_tcu_irq_init);
>>  IRQCHIP_DECLARE(jz4770_tcu_irq, "ingenic,jz4770-tcu", 
>> ingenic_tcu_irq_init);
>> +IRQCHIP_DECLARE(x1000_tcu_irq, "ingenic,x1000-tcu", 
>> ingenic_tcu_irq_init);
>
> Otherwise,
>
> Acked-by: Marc Zyngier <maz@kernel.org>
>
> I expect this to go via the MIPS tree as a series.
>
> Thanks,
>
>         M.


      reply	other threads:[~2020-03-04 11:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  8:29 Add support for TCU of X1000 周琰杰 (Zhou Yanjie)
2020-02-19  8:29 ` [PATCH 0/4] " 周琰杰 (Zhou Yanjie)
2020-02-19  8:29 ` [PATCH 1/4] dt-bindings: timer: Add X1000 bindings 周琰杰 (Zhou Yanjie)
2020-02-26 15:29   ` Rob Herring
2020-02-27 10:22   ` Daniel Lezcano
2020-03-19  8:47   ` [tip: timers/core] " tip-bot2 for 周琰杰
2020-02-19  8:29 ` [PATCH 2/4] clk: Ingenic: Add support for TCU of X1000 周琰杰 (Zhou Yanjie)
2020-03-04 10:41   ` Zhou Yanjie
2020-03-20 23:59   ` Stephen Boyd
2020-02-19  8:29 ` [PATCH 3/4] clocksource: " 周琰杰 (Zhou Yanjie)
2020-02-27 10:23   ` Daniel Lezcano
2020-03-19  8:47   ` [tip: timers/core] clocksource/drivers/ingenic: " tip-bot2 for 周琰杰
2020-02-19  8:29 ` [PATCH 4/4] irqchip: Ingenic: " 周琰杰 (Zhou Yanjie)
2020-03-04 10:58   ` Marc Zyngier
2020-03-04 11:22     ` Zhou Yanjie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E5F8F76.6060803@wanyeetech.com \
    --to=zhouyanjie@wanyeetech.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dongsheng.qiu@ingenic.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=paul@crapouillou.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sernia.zhou@foxmail.com \
    --cc=tglx@linutronix.de \
    --cc=zhenwenjin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).