linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: srikar@linux.vnet.ibm.com, Oleg Nesterov <oleg@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	mhiramat@kernel.org, Peter Zijlstra <peterz@infradead.org>,
	mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, open list <linux-kernel@vger.kernel.org>,
	ananth@linux.vnet.ibm.com,
	Alexis Berlemont <alexis.berlemont@gmail.com>,
	naveen.n.rao@linux.vnet.ibm.com,
	linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
	linux@armlinux.org.uk, ralf@linux-mips.org, paul.burton@mips.com,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)
Date: Mon, 13 Aug 2018 13:08:34 +0530	[thread overview]
Message-ID: <5b693a28-5a0b-1adc-a805-b66dfbe7bdd7@linux.ibm.com> (raw)
In-Reply-To: <95a1221e-aecc-42be-5239-a2c2429be176@linux.ibm.com>

Hi Song,

On 08/13/2018 11:17 AM, Ravi Bangoria wrote:
>>> +
>>> +static void delayed_uprobe_remove(struct uprobe *uprobe, struct mm_struct *mm)
>>> +{
>>> +       struct list_head *pos, *q;
>>> +       struct delayed_uprobe *du;
>>> +
>>> +       if (!uprobe && !mm)
>>> +               return;
>> And do we really need this check?
> 
> 
> Yes. delayed_uprobe_remove(uprobe=NULL, mm=NULL) is an invalid case. If I remove
> this check, code below (or more accurately code suggested by Oleg) will remove
> all entries from delayed_uprobe_list. So I will keep this check but put a comment
> above function.
> 

Sorry, my bad. Please ignore above comment. Even though, it saves us
to unnecessary loop over entire delayed_uprobe_list when both uprobe
and mm are NULL, that case is not possible with current code. Also,
I'm not dereferencing any of them. So, IMHO it's fine to remove this
check.

Thanks,
Ravi


  reply	other threads:[~2018-08-13  7:38 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  4:18 [PATCH v8 0/6] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-08-09  4:18 ` [PATCH v8 1/6] Uprobes: Simplify uprobe_register() body Ravi Bangoria
2018-08-11  8:00   ` Song Liu
2018-08-13  8:56   ` Srikar Dronamraju
2018-08-14  0:07     ` Steven Rostedt
2018-08-09  4:18 ` [PATCH v8 2/6] Uprobe: Additional argument arch_uprobe to uprobe_write_opcode() Ravi Bangoria
2018-08-11  8:01   ` Song Liu
2018-08-13  8:51   ` Srikar Dronamraju
2018-08-09  4:18 ` [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-08-09 14:38   ` Oleg Nesterov
2018-08-10 19:58     ` Steven Rostedt
2018-08-11  6:14       ` Song Liu
2018-08-14  0:01         ` Steven Rostedt
2018-08-14  0:05           ` Steven Rostedt
2018-08-11  7:57   ` Song Liu
2018-08-11 15:37     ` Steven Rostedt
2018-08-13  5:47     ` Ravi Bangoria
2018-08-13  7:38       ` Ravi Bangoria [this message]
2018-08-13 11:50       ` Oleg Nesterov
2018-08-13 13:01         ` Ravi Bangoria
2018-08-13 13:17           ` Oleg Nesterov
2018-08-13 14:26             ` Ravi Bangoria
2018-08-13 14:51             ` Oleg Nesterov
2018-08-13 17:12             ` Song Liu
2018-08-14  4:37               ` Ravi Bangoria
2018-08-14 16:35                 ` Song Liu
2018-08-14  0:03         ` Steven Rostedt
2018-08-13 16:50       ` Song Liu
2018-08-13 10:03   ` Srikar Dronamraju
2018-08-13 11:23     ` Oleg Nesterov
2018-08-14  8:56   ` Ravi Bangoria
2018-08-09  4:18 ` [PATCH v8 4/6] Uprobes/sdt: Prevent multiple reference counter for same uprobe Ravi Bangoria
2018-08-11  8:04   ` Song Liu
2018-08-13  8:50   ` Srikar Dronamraju
2018-08-09  4:18 ` [PATCH v8 5/6] trace_uprobe/sdt: " Ravi Bangoria
2018-08-11  8:12   ` Song Liu
2018-08-13  8:19     ` Ravi Bangoria
2018-08-13  8:49       ` Srikar Dronamraju
2018-08-13 16:27         ` Song Liu
2018-08-13  8:48   ` Srikar Dronamraju
2018-08-09  4:18 ` [PATCH v8 6/6] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-08-13 16:55 ` [PATCH v8 0/6] Uprobes: Support SDT markers having reference count (semaphore) Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b693a28-5a0b-1adc-a805-b66dfbe7bdd7@linux.ibm.com \
    --to=ravi.bangoria@linux.ibm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexis.berlemont@gmail.com \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux@armlinux.org.uk \
    --cc=liu.song.a23@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=oleg@redhat.com \
    --cc=paul.burton@mips.com \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).