From: Can Guo <cang@codeaurora.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, Jaegeuk Kim <jaegeuk@google.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>
Subject: Re: [PATCH 3/4] scsi: ufs: use WQ_HIGHPRI for gating work
Date: Tue, 20 Oct 2020 10:19:53 +0800 [thread overview]
Message-ID: <5c383fd90a0e97dbd1fffc35574133c9@codeaurora.org> (raw)
In-Reply-To: <20201005223635.2922805-3-jaegeuk@kernel.org>
On 2020-10-06 06:36, Jaegeuk Kim wrote:
> From: Jaegeuk Kim <jaegeuk@google.com>
>
> Must have WQ_MEM_RECLAIM
> ``WQ_MEM_RECLAIM``
> All wq which might be used in the memory reclaim paths **MUST**
> have this flag set. The wq is guaranteed to have at least one
> execution context regardless of memory pressure.
>
The commit msg is not telling the same story as the change/title does.
Regards,
Can Guo.
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Avri Altman <avri.altman@wdc.com>
> Cc: Can Guo <cang@codeaurora.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@google.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 0bb07b50bd23e..76e95963887be 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1849,7 +1849,7 @@ static void ufshcd_init_clk_gating(struct ufs_hba
> *hba)
> snprintf(wq_name, ARRAY_SIZE(wq_name), "ufs_clk_gating_%d",
> hba->host->host_no);
> hba->clk_gating.clk_gating_workq = alloc_ordered_workqueue(wq_name,
> - WQ_MEM_RECLAIM);
> + WQ_MEM_RECLAIM | WQ_HIGHPRI);
>
> hba->clk_gating.is_enabled = true;
next prev parent reply other threads:[~2020-10-20 2:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 22:36 [PATCH 1/4] scsi: ufs: atomic update for clkgating_enable Jaegeuk Kim
2020-10-05 22:36 ` [PATCH 2/4] scsi: ufs: clear UAC for FFU and RPMB LUNs Jaegeuk Kim
2020-10-20 2:17 ` Can Guo
2020-10-20 18:36 ` jaegeuk
2020-10-05 22:36 ` [PATCH 3/4] scsi: ufs: use WQ_HIGHPRI for gating work Jaegeuk Kim
2020-10-20 2:19 ` Can Guo [this message]
2020-10-20 18:27 ` jaegeuk
2020-10-05 22:36 ` [PATCH 4/4] scsi: add more contexts in the ufs tracepoints Jaegeuk Kim
2020-10-20 2:18 ` Can Guo
2020-10-20 10:51 ` Avri Altman
2020-10-20 11:02 ` Can Guo
2020-10-20 11:54 ` Avri Altman
2020-10-20 11:57 ` Can Guo
2020-10-20 12:33 ` Can Guo
2020-10-20 2:30 ` [PATCH 1/4] scsi: ufs: atomic update for clkgating_enable Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c383fd90a0e97dbd1fffc35574133c9@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=jaegeuk@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).