From: "liwei (GF)" <liwei391@huawei.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jason Wessel <jason.wessel@windriver.com>,
Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
David Miller <davem@davemloft.net>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>, <liwei1412@163.com>
Subject: Re: [PATCH 4/4] arm64: kgdb: Set PSTATE.SS to 1 to reenable single-step
Date: Sat, 16 May 2020 16:20:44 +0800 [thread overview]
Message-ID: <5cf0ccf6-79e7-7ad4-c007-f0041daf9a42@huawei.com> (raw)
In-Reply-To: <CAD=FV=Vb6=f=fr83-k0YH86k4v4G5LcfOGcks7RM9VxzxOnXsQ@mail.gmail.com>
Hi Douglas,
On 2020/5/14 8:23, Doug Anderson wrote:
(SNIP)
>> diff --git a/arch/arm64/kernel/kgdb.c b/arch/arm64/kernel/kgdb.c
>> index 3910ac06c261..093ad9d2e5e6 100644
>> --- a/arch/arm64/kernel/kgdb.c
>> +++ b/arch/arm64/kernel/kgdb.c
>> @@ -230,7 +230,8 @@ int kgdb_arch_handle_exception(int exception_vector, int signo,
>> kernel_prepare_single_step(&per_cpu(kgdb_ss_flags,
>> raw_smp_processor_id()), linux_regs);
>> kernel_enable_single_step(linux_regs);
>> - }
>> + } else
>> + set_regs_spsr_ss(linux_regs);
>
> One slight nit is that my personal preference is that if one half of
> an "if/else" needs braces then both halves should have braces. I
Thanks for spotting it. Refer to Documentation/process/coding-style.rst,
i will fix it in the v2.
> don't know what Catalin and Will's policies are, though.
>
> Other than that, this seems right to me. I will leave it to the
> Catalin and Will folks to say if they'd rather have this call made
> from a different place or if they're happy with where you've put it.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Douglas Anderson <dianders@chromium.org>
>
Thanks,
Wei
next prev parent reply other threads:[~2020-05-16 8:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 21:41 [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues Wei Li
2020-05-09 21:41 ` [PATCH 1/4] arm64: kgdb: Fix single-step exception handling oops Wei Li
2020-05-14 0:21 ` Doug Anderson
2020-05-09 21:41 ` [PATCH 2/4] arm64: Extract kprobes_save_local_irqflag() and kprobes_restore_local_irqflag() Wei Li
2020-05-10 8:59 ` Masami Hiramatsu
2020-05-14 0:21 ` Doug Anderson
2020-05-16 8:47 ` liwei (GF)
2020-05-16 16:17 ` Doug Anderson
2020-05-18 15:14 ` Masami Hiramatsu
2020-05-09 21:41 ` [PATCH 3/4] arm64: kgdb: Fix single-stepping into the irq handler wrongly Wei Li
2020-05-14 0:21 ` Doug Anderson
2020-05-09 21:41 ` [PATCH 4/4] arm64: kgdb: Set PSTATE.SS to 1 to reenable single-step Wei Li
2020-05-14 0:23 ` Doug Anderson
2020-05-16 8:20 ` liwei (GF) [this message]
2020-05-14 0:34 ` [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues Doug Anderson
2020-05-16 8:20 ` liwei (GF)
2020-06-29 21:20 ` Doug Anderson
2020-06-30 7:22 ` Will Deacon
2020-07-06 21:37 ` Doug Anderson
2020-07-08 22:06 ` Will Deacon
2020-07-08 22:22 ` Doug Anderson
2020-07-07 1:37 ` liwei (GF)
2020-07-08 22:02 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf0ccf6-79e7-7ad4-c007-f0041daf9a42@huawei.com \
--to=liwei391@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei1412@163.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).