From: Alex Ghiti <alex@ghiti.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
DTML <devicetree@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -fixes] riscv: Fix BUILTIN_DTB for sifive and microchip soc
Date: Sun, 6 Jun 2021 09:40:34 +0200 [thread overview]
Message-ID: <5d3a00d1-9e45-398a-39cf-1e6e9924eb18@ghiti.fr> (raw)
In-Reply-To: <CAK8P3a1_N6dAdjWR10FtgaVz828o7W5Mp55DO3Ex+3en-ikOUw@mail.gmail.com>
Le 5/06/2021 à 13:00, Arnd Bergmann a écrit :
> On Sat, Jun 5, 2021 at 8:37 AM Alex Ghiti <alex@ghiti.fr> wrote:
>> Le 4/06/2021 à 15:08, Arnd Bergmann a écrit :
>>> On Fri, Jun 4, 2021 at 2:06 PM Alexandre Ghiti <alex@ghiti.fr> wrote:
>>>>
>>>> Fix BUILTIN_DTB config which resulted in a dtb that was actually not built
>>>> into the Linux image: in the same manner as Canaan soc does, create an object
>>>> file from the dtb file that will get linked into the Linux image.
>>>>
>>>> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
>>>
>>> Along the same lines as the comment that Jisheng Zhang made on the fixed
>>> address, building a dtb into the kernel itself fundamentally breaks generic
>>> kernel images.
>>>
>>> I can understand using it on K210, which is extremely limited and wouldn't
>>> run a generic kernel anyway, but for normal platforms like microchip and
>>> sifive, it would be better to disallow CONFIG_BUILTIN_DTB in Kconfig
>>> and require a non-broken boot loader.
>>
>> I kind of disagree because if I want to build a custom kernel for those
>> platforms with a builtin dtb for some reasons (debug, development..Etc),
>> I think I should be able to do so.
>
> How is the builtin dtb better than appended dtb, or passing the dtb to the
> boot loader in that case?
Ah never said it was better, just it was available so there is no reason
we could not allow it :)
>
> Arnd
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
next prev parent reply other threads:[~2021-06-06 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 12:06 [PATCH -fixes] riscv: Fix BUILTIN_DTB for sifive and microchip soc Alexandre Ghiti
2021-06-04 13:08 ` Arnd Bergmann
2021-06-04 15:51 ` Palmer Dabbelt
2021-06-04 18:34 ` Arnd Bergmann
2021-06-04 17:45 ` Vitaly Wool
2021-06-04 18:33 ` Arnd Bergmann
2021-06-05 6:33 ` Alex Ghiti
2021-06-05 11:00 ` Arnd Bergmann
2021-06-06 7:40 ` Alex Ghiti [this message]
2021-06-12 4:10 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d3a00d1-9e45-398a-39cf-1e6e9924eb18@ghiti.fr \
--to=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).