From: Stephen Boyd <swboyd@chromium.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Mark Brown <broonie@kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Markus Elfring <Markus.Elfring@web.de>
Subject: Re: [PATCH v5 2/3] treewide: Remove dev_err() usage after platform_get_irq()
Date: Tue, 30 Jul 2019 10:21:41 -0700 [thread overview]
Message-ID: <5d407ca6.1c69fb81.a0835.69e0@mx.google.com> (raw)
In-Reply-To: <CAHp75VeiMY4snbDkM=hdqRoUQZ5bEmhjEMdinmvV1voQhWfANg@mail.gmail.com>
Quoting Andy Shevchenko (2019-07-30 10:17:46)
> On Tue, Jul 30, 2019 at 8:16 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Tue, Jul 30, 2019 at 6:36 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > > Quoting Greg Kroah-Hartman (2019-07-29 23:49:17)
> > > > On Mon, Jul 29, 2019 at 10:38:44PM -0700, Stephen Boyd wrote:
> > > > > We don't need dev_err() messages when platform_get_irq() fails now that
> > > > > platform_get_irq() prints an error message itself when something goes
> > > > > wrong. Let's remove these prints with a simple semantic patch.
> >
> > > > Can you just break this up into per-subsystem pieces and send it through
> > > > those trees, and any remaining ones I can take, but at least give
> > > > maintainers a chance to take it.
> > >
> > > Ok. Let me resend just this patch broken up into many pieces.
> >
> > Please, for the subsystems / drivers where I'm the (co-)maintainer,
> > please split on per driver / module basis.
> > I will pickup them preventively, since it will be anyway run-time
> > bisectability breakage.
>
> However, having two messages slightly better than none from user prospective...
>
I only have this diffstat showing your name.
drivers/platform/mellanox/mlxreg-hotplug.c | 5 +----
drivers/platform/x86/intel_bxtwc_tmu.c | 5 +----
drivers/platform/x86/intel_int0002_vgpio.c | 4 +---
drivers/platform/x86/intel_pmc_ipc.c | 4 +---
You want a patch per line above?
next prev parent reply other threads:[~2019-07-30 17:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 5:38 [PATCH v5 0/3] Add error message to platform_get_irq*() Stephen Boyd
2019-07-30 5:38 ` [PATCH v5 1/3] driver core: platform: Add an " Stephen Boyd
2019-07-30 9:44 ` Markus Elfring
2019-07-30 12:30 ` Markus Elfring
2019-07-30 5:38 ` [PATCH v5 2/3] treewide: Remove dev_err() usage after platform_get_irq() Stephen Boyd
2019-07-30 6:49 ` Greg Kroah-Hartman
2019-07-30 15:35 ` Stephen Boyd
2019-07-30 15:51 ` Greg Kroah-Hartman
2019-07-30 17:16 ` Andy Shevchenko
2019-07-30 17:17 ` Andy Shevchenko
2019-07-30 17:21 ` Stephen Boyd [this message]
2019-07-30 17:31 ` Andy Shevchenko
2019-07-30 10:00 ` [v5 " Markus Elfring
2019-07-30 10:00 ` Markus Elfring
2019-07-30 5:38 ` [PATCH v5 3/3] coccinelle: Add script to check for platform_get_irq() excessive prints Stephen Boyd
2019-07-30 8:49 ` Markus Elfring
2019-07-31 14:26 ` [Cocci] [PATCH v5 0/3] Add error message to platform_get_irq*() Wolfram Sang
2019-07-31 14:52 ` Stephen Boyd
2019-08-01 12:25 ` Wolfram Sang
2019-08-08 7:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d407ca6.1c69fb81.a0835.69e0@mx.google.com \
--to=swboyd@chromium.org \
--cc=Markus.Elfring@web.de \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).