From: Stephen Boyd <swboyd@chromium.org>
To: Jack Pham <jackp@codeaurora.org>,
Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
robh@kernel.org, andy.gross@linaro.org, shawn.guo@linaro.org,
gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, khasim.mohammed@linaro.org
Subject: Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings
Date: Thu, 05 Sep 2019 22:26:12 -0700 [thread overview]
Message-ID: <5d71edf5.1c69fb81.1f307.fdd6@mx.google.com> (raw)
In-Reply-To: <20190905175802.GA19599@jackp-linux.qualcomm.com>
Quoting Jack Pham (2019-09-05 10:58:02)
> Hi Jorge, Bjorn,
>
> On Thu, Sep 05, 2019 at 09:18:57AM +0200, Jorge Ramirez wrote:
> > On 9/4/19 01:34, Bjorn Andersson wrote:
> > > On Tue 03 Sep 14:45 PDT 2019, Stephen Boyd wrote:
> > >> that would need an of_regulator_get() sort of API that can get the
> > >> regulator out of there? Or to make the connector into a struct device
> > >> that can get the regulator out per some generic connector driver and
> > >> then pass it through to the USB controller when it asks for it. Maybe
> > >> try to prototype that out?
> > >>
> > >
> > > The examples given in the DT bindings describes the connector as a child
> > > of a PMIC, with of_graph somehow tying it to the various inputs. But in
> > > these examples vbus is handled by implicitly inside the MFD, where
> > > extcon is informed about the plug event they toggle vbus as well.
> > >
> > > In our case we have a extcon-usb-gpio to detect mode, which per Jorge's
> > > proposal will trickle down to the PHY and become a regulator calls on
> > > either some external regulator or more typically one of the chargers in
> > > the system.
>
> Interesting you mention extcon-usb-gpio. I thought extcon at least from
> bindings perspective is passé now. Maybe this is what you need (just
> landed in usb-next):
>
> usb: common: add USB GPIO based connection detection driver
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=4602f3bff2669012c1147eecfe74c121765f5c56
>
> dt-bindings: usb: add binding for USB GPIO based connection detection driver
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=f651c73e71f53f65e9846677d79d8e120452b59f
>
> Fortunately this new driver might check the right boxes for you:
> - usb connector binding
> - ID detect GPIO
> - vbus-supply regulator
>
> With that, I think you can also keep the connector subnode out of the
> SSPHY node well, and similarly get rid of the vbus toggle handling from
> the PHY driver.
>
> The big thing missing now is that this driver replaces extcon
> completely, so we'll need handling in dwc3/dwc3-qcom to retrieve the
> role switch state to know when host mode is entered. I saw this a while
> back but don't think it got picked up:
>
> https://patchwork.kernel.org/patch/10909981/
>
Yes this looks like the approach that should be taken. One question
though, is this a micro-b connector or a type-c connector on the board?
I thought it was a type-c, so then this USB gpio based connection driver
isn't an exact fit?
next prev parent reply other threads:[~2019-09-06 5:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 11:17 [PATCH v4 0/4] USB SS PHY for Qualcomm's QCS404 Jorge Ramirez-Ortiz
2019-02-07 11:17 ` [PATCH v4 1/4] dt-bindings: phy: remove qcom-dwc3-usb-phy Jorge Ramirez-Ortiz
2019-02-13 21:44 ` Rob Herring
2019-02-07 11:17 ` [PATCH v4 2/4] dt-bindings: connector: Add vbus-supply property Jorge Ramirez-Ortiz
2019-02-13 21:44 ` Rob Herring
2019-02-07 11:17 ` [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings Jorge Ramirez-Ortiz
2019-02-13 21:43 ` Rob Herring
2019-02-23 16:52 ` Bjorn Andersson
2019-08-29 7:03 ` Jorge Ramirez
2019-08-30 16:01 ` Stephen Boyd
2019-08-30 16:45 ` Bjorn Andersson
2019-08-30 18:28 ` Stephen Boyd
2019-09-02 6:23 ` Jorge Ramirez
2019-09-03 17:39 ` Jack Pham
2019-09-03 21:45 ` Stephen Boyd
2019-09-03 23:34 ` Bjorn Andersson
2019-09-05 7:18 ` Jorge Ramirez
2019-09-05 17:58 ` Jack Pham
2019-09-06 5:26 ` Stephen Boyd [this message]
2019-09-06 18:25 ` Bjorn Andersson
2019-09-06 20:40 ` Stephen Boyd
2019-02-07 11:17 ` [PATCH v4 4/4] phy: qualcomm: usb: Add SuperSpeed PHY driver Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d71edf5.1c69fb81.1f307.fdd6@mx.google.com \
--to=swboyd@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=khasim.mohammed@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).