From: poza@codeaurora.org
To: Ray Jui <ray.jui@broadcom.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Bjorn Helgaas <helgaas@kernel.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
linux-pci-owner@vger.kernel.org
Subject: Re: [PATCH v2 3/5] PCI: iproc: Disable MSI parsing in certain PAXC blocks
Date: Tue, 12 Jun 2018 23:14:59 +0530 [thread overview]
Message-ID: <5dab98f1205c33320422ea1732bc6fba@codeaurora.org> (raw)
In-Reply-To: <c44bf00c-b412-2cd1-75ee-7541bc775173@broadcom.com>
On 2018-06-12 22:28, Ray Jui wrote:
> On 6/12/2018 1:29 AM, poza@codeaurora.org wrote:
>> On 2018-06-12 05:51, Ray Jui wrote:
>>> The internal MSI parsing logic in certain revisions of PAXC root
>>> complexes does not work properly and can casue corruptions on the
>>> writes. They need to be disabled
>>>
>>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
>>> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>>> ---
>>> drivers/pci/host/pcie-iproc.c | 34
>>> ++++++++++++++++++++++++++++++++--
>>> 1 file changed, 32 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/pci/host/pcie-iproc.c
>>> b/drivers/pci/host/pcie-iproc.c
>>> index 680f6b1..0804aa2 100644
>>> --- a/drivers/pci/host/pcie-iproc.c
>>> +++ b/drivers/pci/host/pcie-iproc.c
>>> @@ -1197,10 +1197,22 @@ static int
>>> iproc_pcie_paxb_v2_msi_steer(struct
>>> iproc_pcie *pcie, u64 msi_addr)
>>> return ret;
>>> }
>>>
>>> -static void iproc_pcie_paxc_v2_msi_steer(struct iproc_pcie *pcie,
>>> u64 msi_addr)
>>> +static void iproc_pcie_paxc_v2_msi_steer(struct iproc_pcie *pcie,
>>> u64 msi_addr,
>>> + bool enable)
>>> {
>>> u32 val;
>>>
>>> + if (!enable) {
>>> + /*
>>> + * Disable PAXC MSI steering. All write transfers will be
>>> + * treated as non-MSI transfers
>>> + */
>>> + val = iproc_pcie_read_reg(pcie, IPROC_PCIE_MSI_EN_CFG);
>>> + val &= ~MSI_ENABLE_CFG;
>>> + iproc_pcie_write_reg(pcie, IPROC_PCIE_MSI_EN_CFG, val);
>>> + return;
>> can be dropped.
>
>
> No it cannot be dropped. Please review the code carefully.
Ahhh, my bad, it looked like a new function to me, may e I need sleep.
sorry about that.
Reviewed-by: Oza Pawandeep <poza@codeaurora.org>
next prev parent reply other threads:[~2018-06-12 17:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 0:21 [PATCH v2 0/5] Improve Broadcom PAXC support Ray Jui
2018-06-12 0:21 ` [PATCH v2 1/5] PCI: iproc: Activate PAXC bridge quirk for more devices Ray Jui
2018-06-12 8:30 ` poza
2018-07-09 17:32 ` Ray Jui
2018-07-11 13:11 ` Bjorn Helgaas
2018-07-11 16:52 ` Ray Jui
2018-06-12 0:21 ` [PATCH v2 2/5] PCI: iproc: Fix up corrupted PAXC root complex config registers Ray Jui
2018-06-12 8:27 ` poza
2018-06-12 12:23 ` poza
2018-06-12 16:56 ` Ray Jui
2018-06-12 0:21 ` [PATCH v2 3/5] PCI: iproc: Disable MSI parsing in certain PAXC blocks Ray Jui
2018-06-12 8:29 ` poza
2018-06-12 16:58 ` Ray Jui
2018-06-12 17:44 ` poza [this message]
2018-06-12 0:21 ` [PATCH v2 4/5] PCI: iproc: Reject unconfigured physical functions from PAXC Ray Jui
2018-06-12 8:30 ` poza
2018-06-12 0:21 ` [PATCH v2 5/5] PCI: iproc: Reduce inbound/outbound mapping print level Ray Jui
2018-06-12 8:31 ` poza
2018-06-20 17:26 ` [PATCH v2 0/5] Improve Broadcom PAXC support Ray Jui
2018-06-21 16:48 ` Lorenzo Pieralisi
2018-06-21 18:22 ` Ray Jui
2018-07-04 5:02 ` Ray Jui
2018-07-06 16:20 ` Lorenzo Pieralisi
2018-07-06 22:47 ` Ray Jui
2018-07-09 17:22 ` Lorenzo Pieralisi
2018-07-09 17:29 ` Ray Jui
2018-07-13 13:05 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dab98f1205c33320422ea1732bc6fba@codeaurora.org \
--to=poza@codeaurora.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci-owner@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=ray.jui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).