From: Jiri Slaby <jslaby@suse.cz>
To: Antoine Robertson <antoinerbrtsn@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: moxa: Fix coding style issues
Date: Tue, 22 Jan 2019 12:16:35 +0100 [thread overview]
Message-ID: <5dd89334-8703-760d-4295-e626cc65ea19@suse.cz> (raw)
In-Reply-To: <20190121224543.5150-1-antoinerbrtsn@gmail.com>
On 21. 01. 19, 23:45, Antoine Robertson wrote:
> Fix coding style issues
>
> Signed-off-by: Antoine Robertson <antoinerbrtsn@gmail.com>
> ---
> drivers/tty/moxa.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 3a1a5e0ee93f..9b6dcb4f7905 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
...
> @@ -1159,9 +1158,8 @@ static int moxa_open(struct tty_struct *tty, struct file *filp)
> int port;
>
> port = tty->index;
> - if (port == MAX_PORTS) {
> + if (port == MAX_PORTS)
> return capable(CAP_SYS_ADMIN) ? 0 : -EPERM;
> - }
Put a newline instead here, please.
> if (mutex_lock_interruptible(&moxa_openlock))
> return -ERESTARTSYS;
> brd = &moxa_boards[port / MAX_PORTS_PER_BOARD];
--
js
suse labs
next prev parent reply other threads:[~2019-01-22 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 22:45 [PATCH v2] tty: moxa: Fix coding style issues Antoine Robertson
2019-01-22 7:15 ` Greg KH
2019-01-22 11:16 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-19 22:52 Antoine Robertson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd89334-8703-760d-4295-e626cc65ea19@suse.cz \
--to=jslaby@suse.cz \
--cc=antoinerbrtsn@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).