From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH RESEND v3 2/7] rtc-mc146818-lib: fix RTC presence check
Date: Fri, 10 Dec 2021 20:05:38 +0100 [thread overview]
Message-ID: <5efcbdad-972d-2159-34ea-97eb6e29c613@o2.pl> (raw)
In-Reply-To: <YbNxum2SgyW97dyB@piout.net>
W dniu 10.12.2021 o 16:26, Alexandre Belloni pisze:
> Hi,
>
> On 25/11/2021 23:12:42+0100, Mateusz Jończyk wrote:
>> W dniu 24.11.2021 o 23:31, Alexandre Belloni pisze:
>>> Hello,
>>>
>>> By moving this patch later on in the series, you'd avoid the subsequent
>>> refactor. I think this would be better for bisection later on.
>> Hi,
>>
>> There are three issues I'm trying to fix in this series:
>>
>> 1. (less important) Insufficient locking in cmos_set_alarm()
>> 2. misdetection of the RTC CMOS as broken on some motherboards,
>> 3. reading / writing of the RTC alarm time during RTC update-in-progress.
>>
>> Do you mean I should drop the patch
>> nr 2. ("rtc-mc146818-lib: fix RTC presence check")
>> and instead straight away introduce mc146818_avoid_UIP() with the new approach (as in patch 3 in the series),
>> then modify mc146818_get_time() to use it (as in patch 4 - fixing issue nr 2),
>> then modify cmos_read_alarm / cmos_set_alarm to use mc146818_avoid_UIP() (patches 5-6, fixing issue no. 3)?
>>
>> I was afraid this risks some confusion what is being fixed when.
> I realize I never replied to this. This is fine, I'm planning to apply
> the whole series once the few comments are fixed.
Great!
I've got other things mostly sorted out and tested, so I'll send a v4 shortly after some last-minute checks.
> We'll probably get some breakage later on because many RTCs using this
> driver are not adhering to the spec.
>
Thanks,
Mateusz
next prev parent reply other threads:[~2021-12-10 19:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 20:42 [PATCH RESEND v3 0/7] rtc-cmos,rtc-mc146818-lib: fixes Mateusz Jończyk
2021-11-19 20:42 ` [PATCH RESEND v3 1/7] rtc-cmos: take rtc_lock while reading from CMOS Mateusz Jończyk
2021-11-19 20:42 ` [PATCH RESEND v3 2/7] rtc-mc146818-lib: fix RTC presence check Mateusz Jończyk
2021-11-24 22:31 ` Alexandre Belloni
2021-11-25 22:12 ` Mateusz Jończyk
2021-12-10 15:26 ` Alexandre Belloni
2021-12-10 19:05 ` Mateusz Jończyk [this message]
2021-11-19 20:42 ` [PATCH RESEND v3 3/7] rtc-mc146818-lib: extract mc146818_do_avoiding_UIP Mateusz Jończyk
2021-11-24 22:39 ` Alexandre Belloni
2021-11-25 5:28 ` Mateusz Jończyk
2021-11-25 8:04 ` Alexandre Belloni
2021-11-19 20:42 ` [PATCH RESEND v3 4/7] rtc-mc146818-lib: refactor mc146818_get_time Mateusz Jończyk
2021-11-24 22:41 ` Alexandre Belloni
2021-11-25 5:48 ` Mateusz Jończyk
2021-11-25 8:05 ` Alexandre Belloni
2021-11-19 20:42 ` [PATCH RESEND v3 5/7] rtc-mc146818-lib: refactor mc146818_does_rtc_work Mateusz Jończyk
2021-11-19 20:42 ` [PATCH RESEND v3 6/7] rtc-cmos: avoid UIP when reading alarm time Mateusz Jończyk
2021-11-19 20:46 ` [DEBUG PATCH v3] rtc-cmos: cmos_read_alarm bug demonstration Mateusz Jończyk
2021-11-24 22:44 ` [PATCH RESEND v3 6/7] rtc-cmos: avoid UIP when reading alarm time Alexandre Belloni
2021-11-19 20:42 ` [PATCH RESEND v3 7/7] rtc-cmos: avoid UIP when writing " Mateusz Jończyk
2021-11-19 21:20 ` [PATCH RESEND v3 0/7] rtc-cmos,rtc-mc146818-lib: fixes Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5efcbdad-972d-2159-34ea-97eb6e29c613@o2.pl \
--to=mat.jonczyk@o2.pl \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).