From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/2] clocksource/meson6_timer: implement ARM delay timer
Date: Sun, 18 Nov 2018 02:27:16 +0100 [thread overview]
Message-ID: <5ff1a888-cce2-8fd8-a98e-14c3d7c33acf@linaro.org> (raw)
In-Reply-To: <20181115224657.14736-1-martin.blumenstingl@googlemail.com>
On 15/11/2018 23:46, Martin Blumenstingl wrote:
> While trying to add support for the ARM TWD Timer and the ARM Global
> Timer on Meson8, Meson8b and Meson8m2 (ARM Cortex-A5 and Cortex-A9 SoCs)
> I did a review of the existing driver.
> Unfortunately I found it hard to review because the pre-processor
> #defines did not match the names from the public S805 datasheet. Thus
> patch #1 adjusts these. No functional changes here, this is just
> preparation work for patch #2.
>
> Using the ARM Global Timer (drivers/clocksource/arm_global_timer.c)
> would have given us a timer-based delay implementation (so udelay() and
> friends would use the timer instead of using a loop-based delay
> implementation). Unfortunately we can't use the ARM Global Timer yet
> because it's input clock is derived from the CPU clock (which can change
> once we enable CPU frequency scaling on these SoCs, for which I will be
> sending patches in the near future).
> Amlogic's 3.10 kernel uses Timer E as delay timer which (with the
> current configuration) has a resolution of 1us. So patch #2 uses
> register_current_timer_delay() to register Timer E as ARM delay timer
> (which will be especially useful as we have to use udelay() when
> changing the CPU clocks during DVFS).
>
>
> Changes since v1 at [0]:
> - convert the enums for the input clock (meson6_timera_input_clock and
> meson6_timere_input_clock) to simple #defines as these are register
> values and not something driver-internal. All other register values
> are #defines so it makes sense that these are #defines as well.
>
>
> [0] https://patchwork.kernel.org/cover/10658591/
>
>
> Martin Blumenstingl (2):
> clocksource: meson6_timer: use register names from the datasheet
> clocksource: meson6_timer: implement ARM delay timer
>
> drivers/clocksource/meson6_timer.c | 128 +++++++++++++++++++----------
> 1 file changed, 85 insertions(+), 43 deletions(-)
Both applied, thanks!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-11-18 1:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 22:46 [PATCH v2 0/2] clocksource/meson6_timer: implement ARM delay timer Martin Blumenstingl
2018-11-15 22:46 ` [PATCH v2 1/2] clocksource: meson6_timer: use register names from the datasheet Martin Blumenstingl
2018-11-15 22:46 ` [PATCH v2 2/2] clocksource: meson6_timer: implement ARM delay timer Martin Blumenstingl
2018-11-18 1:27 ` Daniel Lezcano [this message]
2018-11-22 22:12 ` [PATCH v2 0/2] clocksource/meson6_timer: " Martin Blumenstingl
2018-11-23 6:15 ` Daniel Lezcano
2018-11-23 19:40 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ff1a888-cce2-8fd8-a98e-14c3d7c33acf@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).