From: David Laight <David.Laight@ACULAB.COM>
To: "'Valdis Klētnieks'" <valdis.kletnieks@vt.edu>
Cc: Kees Cook <keescook@chromium.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc
Date: Thu, 18 Mar 2021 13:38:41 +0000 [thread overview]
Message-ID: <602d6d53962c4567bc1363e58b49c757@AcuMS.aculab.com> (raw)
In-Reply-To: <300176.1616068535@turing-police>
From: Valdis Kletnieks
> Sent: 18 March 2021 11:56
>
> On Thu, 18 Mar 2021 11:41:29 -0000, David Laight said:
>
> > That gcc bug just implies you need a space after "xxx".
> > That is easily fixable in the sources.
>
> It's not quite that simple.
>
> In file included from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/tm.h:27,
> from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/gcc-plugin.h:31,
> from /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/plugin.h:23,
> from scripts/gcc-plugins/gcc-common.h:9,
> from scripts/gcc-plugins/latent_entropy_plugin.c:78:
> >> /usr/lib/gcc/x86_64-linux-gnu/5/plugin/include/config/elfos.h:102:21: warning: invalid suffix on
> literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
> fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\
>
> The problem isn't in a kernel source file...
...
Could you pass -Wno-literal-suffix on plugin builds?
Might be less faff than changing the -std=xxx' parameter.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2021-03-18 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 8:40 [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc Valdis Klētnieks
2021-03-18 5:52 ` Kees Cook
2021-03-18 6:02 ` Valdis Klētnieks
2021-03-18 6:26 ` Miguel Ojeda
2021-03-18 9:07 ` Masahiro Yamada
2021-03-18 11:47 ` Valdis Klētnieks
2021-03-18 11:41 ` David Laight
2021-03-18 11:55 ` Valdis Klētnieks
2021-03-18 13:38 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=602d6d53962c4567bc1363e58b49c757@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=geert@linux-m68k.org \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).