From: Hans Verkuil <hansverk@cisco.com>
To: Joe Perches <joe@perches.com>, Hans Verkuil <hverkuil@xs4all.nl>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH 3/5] media: sunxi: Add A10 CSI driver
Date: Tue, 13 Nov 2018 16:39:42 +0100 [thread overview]
Message-ID: <6153b08e-b81d-8e4a-9fd2-0f593523d8da@cisco.com> (raw)
In-Reply-To: <71d315a34e4b12b0eb1d4c9003b297e46695f9cf.camel@perches.com>
On 11/13/18 16:19, Joe Perches wrote:
> On Tue, 2018-11-13 at 13:24 +0100, Hans Verkuil wrote:
>> On 11/13/18 09:24, Maxime Ripard wrote:
>>> The older CSI drivers have camera capture interface different from the one
>>> in the newer ones.
> []
>>> diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h
> []
>>> + // Videobuf2
>>
>> Doesn't checkpatch.pl --strict complain about the use of '//'?
>
> No, not since
>
> commit dadf680de3c2eb4cba9840619991eda0cfe98778
> Author: Joe Perches <joe@perches.com>
> Date: Tue Aug 2 14:04:33 2016 -0700
>
> checkpatch: allow c99 style // comments
>
> Sanitise the lines that contain c99 comments so that the error doesn't
> get emitted.
>
>
Huh, I'm really out of date. But the good news is that I learned something
new today!
Thank you,
Hans
next prev parent reply other threads:[~2018-11-13 15:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 8:24 [PATCH 0/5] media: Allwinner A10 CSI support Maxime Ripard
2018-11-13 8:24 ` [PATCH 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Maxime Ripard
2018-11-13 8:38 ` Sakari Ailus
2018-11-15 19:04 ` Maxime Ripard
2018-11-21 21:56 ` Sakari Ailus
2018-11-27 15:04 ` Maxime Ripard
2018-11-13 10:34 ` Sakari Ailus
2018-11-13 8:24 ` [PATCH 2/5] media: sunxi: Refactor the Makefile and Kconfig Maxime Ripard
2018-11-13 8:24 ` [PATCH 3/5] media: sunxi: Add A10 CSI driver Maxime Ripard
2018-11-13 8:57 ` Sakari Ailus
2018-11-13 12:24 ` Hans Verkuil
2018-11-13 15:19 ` Joe Perches
2018-11-13 15:39 ` Hans Verkuil [this message]
2018-11-15 20:51 ` Maxime Ripard
2018-11-21 22:01 ` Sakari Ailus
2018-11-22 13:58 ` Maxime Ripard
2018-11-13 12:48 ` Fabio Estevam
2018-11-13 13:37 ` Hans Verkuil
2018-11-13 14:13 ` Fabio Estevam
2018-11-13 14:46 ` Thomas Petazzoni
2018-11-13 8:24 ` [PATCH 4/5] ARM: dts: sun7i: Add CSI0 controller Maxime Ripard
2018-11-13 8:24 ` [PATCH 5/5] DO NOT MERGE: ARM: dts: bananapi: Add Camera support Maxime Ripard
2018-11-27 6:56 ` Jagan Teki
2018-11-27 10:31 ` Maxime Ripard
2018-11-27 11:00 ` Jagan Teki
2018-11-27 15:19 ` Maxime Ripard
2018-11-27 15:34 ` Jagan Teki
2018-11-13 12:30 ` [PATCH 0/5] media: Allwinner A10 CSI support Hans Verkuil
2018-11-13 13:52 ` Maxime Ripard
2018-11-13 14:01 ` Hans Verkuil
2018-11-13 15:52 ` Maxime Ripard
2018-11-13 16:00 ` Hans Verkuil
2018-11-13 16:55 ` Thomas Petazzoni
2018-11-13 17:15 ` Hans Verkuil
2018-11-14 3:24 ` Chen-Yu Tsai
2018-11-15 19:10 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6153b08e-b81d-8e4a-9fd2-0f593523d8da@cisco.com \
--to=hansverk@cisco.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=joe@perches.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).