From: Randy Dunlap <rdunlap@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Steven J. Magnani" <steve@digidescorp.com>,
Michal Simek <monstr@monstr.eu>,
Jason Gunthorpe <jgg@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes
Date: Sun, 1 Sep 2019 12:10:11 -0700 [thread overview]
Message-ID: <6184ffdd-30bf-668a-cdee-88cc8eb2ead7@infradead.org> (raw)
In-Reply-To: <CAHk-=whH+Wzj+h0WzgdLMu+xtFddokoVy8dWWvEJqJRGA_HLmw@mail.gmail.com>
On 9/1/19 10:31 AM, Linus Torvalds wrote:
> On Sun, Sep 1, 2019 at 10:07 AM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> I guess I'll apply it. I'm not sure why you _care_ about microblaze, but ...
It was just a response to the 0day build bot reporting build errors.
> Ugh. As I was going to apply it, my code cleanliness conscience struck.
>
> I can't deal with that unnecessary duplication of code. Does something
> like the attached patch work instead?
>
> Totally untested, but looks much cleaner.
Hm, I'm getting one (confusing) build error, in block/scsi_ioctl.c:
CC block/scsi_ioctl.o
In file included from ../include/linux/uaccess.h:11,
from ../include/linux/highmem.h:9,
from ../include/linux/pagemap.h:11,
from ../include/linux/blkdev.h:16,
from ../block/scsi_ioctl.c:9:
../block/scsi_ioctl.c: In function 'sg_scsi_ioctl':
../arch/microblaze/include/asm/uaccess.h:167:25: error: invalid initializer
typeof(ptr) __gu_ptr = (ptr); \
^
../block/scsi_ioctl.c:426:6: note: in expansion of macro 'get_user'
if (get_user(opcode, sic->data))
^~~~~~~~
--
~Randy
next prev parent reply other threads:[~2019-09-01 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 14:55 [PATCH v3] arch/microblaze: add support for get_user() of size 8 bytes Randy Dunlap
2019-09-01 17:07 ` Linus Torvalds
2019-09-01 17:31 ` Linus Torvalds
2019-09-01 19:10 ` Randy Dunlap [this message]
2019-09-02 2:10 ` Randy Dunlap
2019-09-02 4:58 ` Linus Torvalds
2019-09-02 13:17 ` Michal Simek
2019-09-02 16:52 ` Linus Torvalds
2019-09-13 6:15 ` Michal Simek
2019-09-02 14:07 ` Randy Dunlap
2019-09-01 17:33 ` Michal Simek
2019-09-01 19:11 ` Randy Dunlap
2019-09-02 9:12 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6184ffdd-30bf-668a-cdee-88cc8eb2ead7@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=steve@digidescorp.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).