linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dan Rue <dan.rue@linaro.org>,
	shuah@kernel.org
Subject: Re: linux-next: Signed-off-by missing for commit in the kselftest tree
Date: Tue, 27 Nov 2018 14:17:57 -0700	[thread overview]
Message-ID: <6235956e-5edd-3b7d-1898-ab55094a7e16@kernel.org> (raw)
In-Reply-To: <20181128073603.3786e528@canb.auug.org.au>

On 11/27/18 1:36 PM, Stephen Rothwell wrote:
> Hi Shuah,
> 
> Commit
> 
>    623ea0df7083 ("selftests: firmware: remove use of non-standard diff -Z option")
> 
> is missing a Signed-off-by from its author.
> 

Thanks for catching this. I will fix it. This is the result of change 
log content messing up the commit: The diff -Z in the change log 
resulted in throwing out the Signed-off and Acked-by.

-----------------------------------------------------------------
diff -Z is used to trim the trailing whitespace when comparing the
loaded firmware file with the source firmware file. However, per the
comment in the source code, -Z should not be necessary. In testing, the
input and output files are identical.

Additionally, -Z is not a standard option and is not available in
environments such as busybox. When -Z is not supported, diff fails with
a usage error, which is suppressed, but then causes read_firmwares() to
exit with a false failure message.
--------------------------------------------------------------------

Oh well! I will fix-up the change-log and amend the commit.

thanks,
-- Shuah

  reply	other threads:[~2018-11-27 21:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27 20:36 linux-next: Signed-off-by missing for commit in the kselftest tree Stephen Rothwell
2018-11-27 21:17 ` shuah [this message]
2018-11-27 22:27   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6235956e-5edd-3b7d-1898-ab55094a7e16@kernel.org \
    --to=shuah@kernel.org \
    --cc=dan.rue@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).