From: Jason Wang <jasowang@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>,
virtualization@lists.linux-foundation.org
Cc: Xie Yongji <xieyongji@bytedance.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
linux-kernel@vger.kernel.org, Max Gurtovoy <mgurtovoy@nvidia.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH RFC v2 03/10] vringh: reset kiov 'consumed' field in __vringh_iov()
Date: Mon, 1 Feb 2021 13:40:01 +0800 [thread overview]
Message-ID: <62bb2e93-4ac3-edf5-2baa-4c2be8257cf0@redhat.com> (raw)
In-Reply-To: <20210128144127.113245-4-sgarzare@redhat.com>
On 2021/1/28 下午10:41, Stefano Garzarella wrote:
> __vringh_iov() overwrites the contents of riov and wiov, in fact it
> resets the 'i' and 'used' fields, but also the consumed field should
> be reset to avoid an inconsistent state.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
I had a question(I remember we had some discussion like this but I
forget the conclusion):
I see e.g in vringh_getdesc_kern() it has the following comment:
/*
* Note that you may need to clean up riov and wiov, even on error!
*/
So it looks to me the correct way is to call vringh_kiov_cleanup() before?
Thanks
> ---
> drivers/vhost/vringh.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
> index f68122705719..bee63d68201a 100644
> --- a/drivers/vhost/vringh.c
> +++ b/drivers/vhost/vringh.c
> @@ -290,9 +290,9 @@ __vringh_iov(struct vringh *vrh, u16 i,
> return -EINVAL;
>
> if (riov)
> - riov->i = riov->used = 0;
> + riov->i = riov->used = riov->consumed = 0;
> if (wiov)
> - wiov->i = wiov->used = 0;
> + wiov->i = wiov->used = wiov->consumed = 0;
>
> for (;;) {
> void *addr;
next prev parent reply other threads:[~2021-02-01 6:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 14:41 [PATCH RFC v2 00/10] vdpa: add vdpa simulator for block device Stefano Garzarella
2021-01-28 14:41 ` [PATCH RFC v2 01/10] vdpa_sim: use iova module to allocate IOVA addresses Stefano Garzarella
2021-01-28 14:41 ` [PATCH RFC v2 02/10] vringh: add 'iotlb_lock' to synchronize iotlb accesses Stefano Garzarella
2021-01-29 7:43 ` Jason Wang
[not found] ` <20210129091850.gatf3ih3knw2p4l4@steredhat>
2021-02-01 6:31 ` Jason Wang
2021-01-28 14:41 ` [PATCH RFC v2 03/10] vringh: reset kiov 'consumed' field in __vringh_iov() Stefano Garzarella
2021-02-01 5:40 ` Jason Wang [this message]
2021-02-01 10:21 ` Stefano Garzarella
2021-02-02 3:26 ` Jason Wang
2021-01-28 14:41 ` [PATCH RFC v2 04/10] vringh: implement vringh_kiov_advance() Stefano Garzarella
2021-02-01 5:43 ` Jason Wang
2021-02-01 10:23 ` Stefano Garzarella
2021-01-28 14:41 ` [PATCH RFC v2 05/10] vringh: add vringh_kiov_length() helper Stefano Garzarella
2021-02-01 5:46 ` Jason Wang
2021-01-28 14:41 ` [PATCH RFC v2 06/10] vdpa_sim: cleanup kiovs in vdpasim_free() Stefano Garzarella
2021-02-01 5:47 ` Jason Wang
2021-01-28 14:41 ` [PATCH RFC v2 07/10] vdpa: Remove the restriction that only supports virtio-net devices Stefano Garzarella
2021-01-28 14:41 ` [PATCH RFC v2 08/10] vdpa: add vdpa simulator for block device Stefano Garzarella
2021-01-31 15:31 ` Max Gurtovoy
2021-02-01 8:29 ` Stefano Garzarella
2021-02-01 5:50 ` Jason Wang
2021-02-02 9:34 ` Stefan Hajnoczi
2021-02-02 15:49 ` Stefano Garzarella
2021-02-03 16:45 ` Stefan Hajnoczi
2021-02-04 8:02 ` Stefano Garzarella
2021-01-28 14:41 ` [PATCH RFC v2 09/10] vdpa_sim_blk: implement ramdisk behaviour Stefano Garzarella
2021-02-01 6:03 ` Jason Wang
2021-02-02 9:41 ` Stefan Hajnoczi
2021-01-28 14:41 ` [PATCH RFC v2 10/10] vdpa_sim_blk: handle VIRTIO_BLK_T_GET_ID Stefano Garzarella
2021-02-01 6:04 ` Jason Wang
2021-02-02 9:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62bb2e93-4ac3-edf5-2baa-4c2be8257cf0@redhat.com \
--to=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).