linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Jacob Chen <jacob-chen@iotwrt.com>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	kever.yang@rock-chips.com
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: add ARM Mali GPU node for rk3399
Date: Sat, 01 Jul 2017 18:04:26 +0200	[thread overview]
Message-ID: <6356522.W9n5LLYRuo@phil> (raw)
In-Reply-To: <1498913770-16519-1-git-send-email-jacob-chen@iotwrt.com>

Hi Jacob,

Am Samstag, 1. Juli 2017, 20:56:08 CEST schrieb Jacob Chen:
> Add Mali GPU device tree node for the rk3399 SoC.
> Tested with rockchip-forwardports repo.
> 
> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 1cbd7a2..e795135 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1443,6 +1443,18 @@
>  		status = "disabled";
>  	};
>  
> +	gpu: mali@ff9a0000 {
> +		compatible = "rockchip,rk3399-mali", "arm,mali-t860", "arm,mali-midgard";

this is missing a separate patch adding rockchip,rk3399-mali to 
	Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt

Also arm,mali-midgard is not part of the binding. I just saw that it slipped
into the example in the binding file and also the rk3288.dtsi - which should
be fixed. But the driver should bind against the arm,mali-t860 alone, not
the mali-midgard.


Heiko

      parent reply	other threads:[~2017-07-01 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-01 12:56 [PATCH 1/3] arm64: dts: rockchip: add ARM Mali GPU node for rk3399 Jacob Chen
2017-07-01 12:56 ` [PATCH 2/3] arm64: dts: rockchip: add gpu opp table " Jacob Chen
2017-07-01 16:26   ` Heiko Stuebner
2017-07-01 12:56 ` [PATCH 3/3] arm64: dts: rockchip: enable ARM Mali GPU on rk3399-firefly Jacob Chen
2017-07-01 16:04 ` Heiko Stuebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6356522.W9n5LLYRuo@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jacob-chen@iotwrt.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).