From: Hans de Goede <hdegoede@redhat.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
K@troy.t-8ch.de, Naduvalath@troy.t-8ch.de,
Sumesh <sumesh.k.naduvalath@intel.com>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 6/6] platform/x86: isthp_eclite: only load for matching devices
Date: Mon, 1 Nov 2021 10:59:13 +0100 [thread overview]
Message-ID: <63ee77e1-dac9-ee09-6e11-4d8a091193f1@redhat.com> (raw)
In-Reply-To: <20211029152901.297939-7-linux@weissschuh.net>
Hi,
On 10/29/21 17:29, Thomas Weißschuh wrote:
> Previously it was loaded for all ISHTP devices.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
>
> ---
>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: K Naduvalath, Sumesh <sumesh.k.naduvalath@intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: linux-input@vger.kernel.org
> Cc: platform-driver-x86@vger.kernel.org
> ---
> drivers/platform/x86/intel/ishtp_eclite.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/ishtp_eclite.c b/drivers/platform/x86/intel/ishtp_eclite.c
> index 12fc98a48657..b9fb8f28fd63 100644
> --- a/drivers/platform/x86/intel/ishtp_eclite.c
> +++ b/drivers/platform/x86/intel/ishtp_eclite.c
> @@ -681,6 +681,12 @@ static struct ishtp_cl_driver ecl_ishtp_cl_driver = {
> .driver.pm = &ecl_ishtp_pm_ops,
> };
>
> +static const struct ishtp_device_id ecl_ishtp_id_table[] = {
> + { ecl_ishtp_guid },
> + { }
> +};
> +MODULE_DEVICE_TABLE(ishtp, ecl_ishtp_id_table);
> +
> static int __init ecl_ishtp_init(void)
> {
> return ishtp_cl_driver_register(&ecl_ishtp_cl_driver, THIS_MODULE);
> @@ -698,4 +704,3 @@ MODULE_DESCRIPTION("ISH ISHTP eclite client opregion driver");
> MODULE_AUTHOR("K Naduvalath, Sumesh <sumesh.k.naduvalath@intel.com>");
>
> MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("ishtp:*");
>
next prev parent reply other threads:[~2021-11-01 9:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 15:28 [PATCH 0/6] MODULE_DEVICE_TABLE() support for the ISHTP bus Thomas Weißschuh
2021-10-29 15:28 ` [PATCH 1/6] HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE() Thomas Weißschuh
2021-10-29 15:28 ` [PATCH 2/6] HID: intel-ish-hid: use constants for modaliases Thomas Weißschuh
2021-10-29 15:28 ` [PATCH 3/6] HID: intel-ish-hid: fw-loader: only load for matching devices Thomas Weißschuh
2021-10-29 15:28 ` [PATCH 4/6] HID: intel-ish-hid: hid-client: " Thomas Weißschuh
2021-10-29 15:29 ` [PATCH 5/6] platform/chrome: chros_ec_ishtp: " Thomas Weißschuh
2021-10-29 15:29 ` [PATCH 6/6] platform/x86: isthp_eclite: " Thomas Weißschuh
2021-10-29 15:29 ` Thomas Weißschuh
2021-11-01 9:59 ` Hans de Goede [this message]
2021-11-10 16:44 ` [PATCH 5/6] platform/chrome: chros_ec_ishtp: " Nathan Chancellor
2021-11-10 23:00 ` [PATCH 1/4] HID: intel-ish-hid: fw-loader: constify devicetable initializer Thomas Weißschuh
2021-11-11 9:10 ` Thomas Weißschuh
2021-11-10 23:00 ` [PATCH 2/4] HID: intel-ish-hid: hid-client: " Thomas Weißschuh
2021-11-10 23:00 ` [PATCH 3/4] platform/chrome: chros_ec_ishtp: " Thomas Weißschuh
2021-11-10 23:00 ` [PATCH 4/4] platform/x86: isthp_eclite: " Thomas Weißschuh
2021-11-01 9:58 ` [PATCH 1/6] HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE() Hans de Goede
2021-11-01 10:09 ` Thomas Weißschuh
2021-11-01 10:15 ` Hans de Goede
2021-11-01 9:56 ` [PATCH 0/6] MODULE_DEVICE_TABLE() support for the ISHTP bus Hans de Goede
2021-11-01 10:12 ` Thomas Weißschuh
2021-11-01 10:17 ` Hans de Goede
2021-11-02 11:50 ` Jiri Kosina
2021-11-02 13:17 ` Srinivas Pandruvada
2021-11-09 10:42 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ee77e1-dac9-ee09-6e11-4d8a091193f1@redhat.com \
--to=hdegoede@redhat.com \
--cc=K@troy.t-8ch.de \
--cc=Naduvalath@troy.t-8ch.de \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sumesh.k.naduvalath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).