From: Valentin Schneider <valentin.schneider@arm.com>
To: Will Deacon <will.deacon@arm.com>,
Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, john.stultz@linaro.org
Subject: Re: AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching"
Date: Thu, 16 Aug 2018 14:58:59 +0100 [thread overview]
Message-ID: <6490931d-65b6-e524-f2d0-65cbac0a263b@arm.com> (raw)
In-Reply-To: <20180816102219.GF31093@arm.com>
Hi,
On 16/08/18 11:22, Will Deacon wrote:
> Hi Tuomas, [+John]
>
> On Thu, Aug 16, 2018 at 02:38:51AM +0300, Tuomas Tynkkynen wrote:
>> Booting Linus's master of today with the usual arm64 defconfig fails for
>> me on the Hikey960 board. I've bisected it down to:
>>
>> commit 693350a7998018391852c48f68956cf0f855b2b9 (HEAD, refs/bisect/bad)
>> Author: Will Deacon <will.deacon@arm.com>
>> Date: Tue Jun 19 17:55:28 2018 +0100
>>
>> arm64: insn: Don't fallback on nosync path for general insn patching
>>
>> Here's the boot log with earlycon enabled after which the boot hangs:
>
> Thanks for the boot log, that's really helpful. Please can you try the diff
> below?
>
I get the same "BUG: scheduling while atomic" when running the current master
(f91e654474d413201ae578820fb63f8a811f6c4e), and confirmed that I don't get
it on my setup when checking out the direct parent of 693350a7998018391852c48f68956cf0f855b2b9.
Tried out the diff and the board doesn't seem to die anymore, so FWIW:
Tested-by: Valentin Schneider <valentin.schneider@arm.com>
> Out of interest -- do you know if Hikey960 is used by any boot-testing
> farms? The patch above has been in linux-next for ages, but we didn't see
> any complaints until it hit mainline :(
>
> Cheers,
>
> Will
>
> --->8
>
> diff --git a/arch/arm64/kernel/jump_label.c b/arch/arm64/kernel/jump_label.c
> index c2dd1ad3e648..e0756416e567 100644
> --- a/arch/arm64/kernel/jump_label.c
> +++ b/arch/arm64/kernel/jump_label.c
> @@ -36,7 +36,7 @@ void arch_jump_label_transform(struct jump_entry *entry,
> insn = aarch64_insn_gen_nop();
> }
>
> - aarch64_insn_patch_text(&addr, &insn, 1);
> + aarch64_insn_patch_text_nosync(addr, insn);
> }
>
> void arch_jump_label_transform_static(struct jump_entry *entry,
>
next prev parent reply other threads:[~2018-08-16 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 23:38 AArch64 boot failure on Hikey960 on latest master after "arm64: insn: Don't fallback on nosync path for general insn patching" Tuomas Tynkkynen
2018-08-16 2:25 ` leo.yan
2018-08-16 10:22 ` Will Deacon
2018-08-16 13:58 ` Valentin Schneider [this message]
2018-08-16 17:57 ` John Stultz
2018-08-16 18:37 ` Tuomas Tynkkynen
2018-08-16 18:47 ` John Stultz
2018-08-16 18:31 ` Tuomas Tynkkynen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6490931d-65b6-e524-f2d0-65cbac0a263b@arm.com \
--to=valentin.schneider@arm.com \
--cc=catalin.marinas@arm.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tuomas.tynkkynen@iki.fi \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).