From: "Shenhar, Talel" <talel@amazon.com>
To: Rob Herring <robh@kernel.org>
Cc: <marc.zyngier@arm.com>, <tglx@linutronix.de>,
<jason@lakedaemon.net>, <mark.rutland@arm.com>,
<nicolas.ferre@microchip.com>, <mchehab+samsung@kernel.org>,
<shawn.lin@rock-chips.com>, <gregkh@linuxfoundation.org>,
<dwmw@amazon.co.uk>, <benh@kernel.crashing.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS
Date: Wed, 18 Sep 2019 16:44:11 +0300 [thread overview]
Message-ID: <6965161b-a51c-9e16-f6b8-6f33b40708ee@amazon.com> (raw)
In-Reply-To: <20190918133248.GA16653@bogus>
Tnx Rob for the review.
Shall be part of v3.
Waiting for responses from Arnd and James and will publish v3.
On 9/18/2019 4:35 PM, Rob Herring wrote:
> On Tue, Sep 10, 2019 at 10:05:08PM +0300, Talel Shenhar wrote:
>> Document Amazon's Annapurna Labs POS SoC binding.
>>
>> Signed-off-by: Talel Shenhar <talel@amazon.com>
>> ---
>> .../devicetree/bindings/soc/amazon/amazon,al-pos.txt | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/amazon/amazon,al-pos.txt
> Please convert to DT schema.
>
>> diff --git a/Documentation/devicetree/bindings/soc/amazon/amazon,al-pos.txt b/Documentation/devicetree/bindings/soc/amazon/amazon,al-pos.txt
>> new file mode 100644
>> index 00000000..035cc571
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/amazon/amazon,al-pos.txt
>> @@ -0,0 +1,18 @@
>> +Amazon's Annapurna Labs POS
>> +
>> +POS node is defined to describe the Point Of Serialization (POS) logger
>> +unit.
>> +
>> +Required properties:
>> +- compatible: Shall be "amazon,al-pos".
>> +- reg: POS logger resources.
>> +- interrupts: should contain the interrupt for pos error event.
>> +
>> +Example:
>> +
>> +al_pos {
> Needs a unit-address.
>
>> + compatible = "amazon,al-pos";
>> + reg = <0x0 0xf0070084 0x0 0x00000008>;
>> + interrupt-parent = <&amazon_system_fabric>;
>> + interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
>> +};
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2019-09-18 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 19:05 [PATCH v2 0/3] Amazon's Annapurna Labs POS Driver Talel Shenhar
2019-09-10 19:05 ` [PATCH v2 1/3] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS Talel Shenhar
2019-09-18 13:32 ` Rob Herring
2019-09-18 13:44 ` Shenhar, Talel [this message]
2019-09-10 19:05 ` [PATCH v2 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver Talel Shenhar
2019-09-11 14:15 ` Marc Zyngier
2019-09-12 6:50 ` [UNVERIFIED SENDER] " Shenhar, Talel
2019-09-12 8:50 ` Marc Zyngier
2019-09-12 9:19 ` [UNVERIFIED SENDER] " Shenhar, Talel
2019-09-19 14:42 ` James Morse
2019-09-22 6:55 ` Shenhar, Talel
2019-09-10 19:05 ` [PATCH v2 3/3] soc: amazon: al-pos: cast to u64 before left shifting Talel Shenhar
2019-09-11 14:18 ` Marc Zyngier
2019-09-12 6:51 ` [UNVERIFIED SENDER] " Shenhar, Talel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6965161b-a51c-9e16-f6b8-6f33b40708ee@amazon.com \
--to=talel@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).