From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Joe Perches <joe@perches.com>, apw@canonical.com
Cc: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] checkpatch: get default codespell dictionary path from package location
Date: Tue, 12 Oct 2021 14:28:57 +0300 [thread overview]
Message-ID: <696c2de0-c0f5-285f-b46b-beb8f87d64e8@linux.intel.com> (raw)
In-Reply-To: <510f7db524904e2f87fe4d52018f712e2df3b7bc.camel@perches.com>
On 11/10/2021 19:50, Joe Perches wrote:
> On Mon, 2021-10-11 at 14:49 +0300, Peter Ujfalusi wrote:
>> The standard location of dictionary.txt is under codespell's package, on
>> my machine atm (codespell 2.1, Artix Linux):
>> /usr/lib/python3.9/site-packages/codespell_lib/data/dictionary.txt
>>
>> Since we enable the codespell by default for SOF I have constant:
>> No codespell typos will be found - \
>> file '/usr/share/codespell/dictionary.txt': No such file or directory
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> + # Try to find the codespell install location to use it as default path
>> + if (($codespell || $help) && which("codespell") ne "" && which("python") ne "") {
>> + my $codespell_dict = `python -c "import os.path as op; import codespell_lib; print(op.join(op.dirname(codespell_lib.__file__), 'data', 'dictionary.txt'), end='')" 2> /dev/null`;
>> + $codespellfile = $codespell_dict if (-e $codespell_dict);
>> + }
>
> This is really hard to read.
>
> Can this be written something like
>
> my $python_codespell_dict = << "EOF"
> import os.path as op
> import codespell_lib
> codespell_dir = op.dirname(codespell_lib.__file__)
> codespell_file = op.join(codespell_dir, 'data', 'dictionary.txt')
> print(codespell_file)
> EOF
> ;
> my $codespell_dict = `python3 -c "$python_codespell_dict" 2> /dev/null`;
Yes, this definitely looks much better, thanks for the suggestion!
--
Péter
prev parent reply other threads:[~2021-10-12 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 11:49 [PATCH v4] checkpatch: get default codespell dictionary path from package location Peter Ujfalusi
2021-10-11 16:50 ` Joe Perches
2021-10-12 11:28 ` Péter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696c2de0-c0f5-285f-b46b-beb8f87d64e8@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).