From: Hannes Reinecke <hare@suse.de>
To: Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: myrs: only build on little-endian platforms
Date: Mon, 5 Nov 2018 08:54:06 +0100 [thread overview]
Message-ID: <69fd8fbd-987a-c48e-6732-387239c3ab0e@suse.de> (raw)
In-Reply-To: <20181102154740.2011289-1-arnd@arndb.de>
On 11/2/18 4:47 PM, Arnd Bergmann wrote:
> Reading throught the new driver, I noticed that this cannot work on
> big-endian CPUs, and the old DAC960 had exactly the same behavior.
>
> To document this for the future, add a Kconfig dependency that prevents it
> from being included in big-endian kernels. Since the hardware is really
> old and we never had a working driver on it for big-endian platforms,
> it's unlikely to make a difference to users.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/scsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index f07444d30b21..640cd1b31a18 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -578,6 +578,7 @@ config SCSI_MYRB
> config SCSI_MYRS
> tristate "Mylex DAC960/DAC1100 PCI RAID Controller (SCSI Interface)"
> depends on PCI
> + depends on !CPU_BIG_ENDIAN || COMPILE_TEST
> select RAID_ATTRS
> help
> This driver adds support for the Mylex DAC960, AcceleRAID, and
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-11-05 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 15:47 [PATCH] scsi: myrs: only build on little-endian platforms Arnd Bergmann
2018-11-05 7:54 ` Hannes Reinecke [this message]
2018-11-06 3:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69fd8fbd-987a-c48e-6732-387239c3ab0e@suse.de \
--to=hare@suse.de \
--cc=arnd@arndb.de \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).