From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
NeilBrown <neil@brown.name>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Marek Belisko <marek@goldelico.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, letux-kernel@openphoenux.org,
notasas@gmail.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v7 1/2] power: supply: twl4030-charger: move irq allocation to just before irqs are enabled
Date: Mon, 3 Jul 2017 18:36:06 +0200 [thread overview]
Message-ID: <6B48E0E0-3AA6-4815-A549-868B57614F51@goldelico.com> (raw)
In-Reply-To: <20170703125556.kaeds2qwk3hxgkw4@earth>
[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]
Hi,
> Am 03.07.2017 um 14:55 schrieb Sebastian Reichel <sebastian.reichel@collabora.co.uk>:
>
> Hi,
>
> On Mon, Jun 19, 2017 at 10:41:45AM +0200, H. Nikolaus Schaller wrote:
>> And initialize workers and notifiers as soon as possible.
>>
>> This avoids a potential race if irqs are enabled and triggered too early
>> before the worker is properly set up.
>>
>> Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> drivers/power/supply/twl4030_charger.c | 29 +++++++++++++++--------------
>> 1 file changed, 15 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c
>> index 1fbbe0cc216a..9d974f1e3957 100644
>> --- a/drivers/power/supply/twl4030_charger.c
>> +++ b/drivers/power/supply/twl4030_charger.c
>> @@ -984,12 +984,27 @@ static int twl4030_bci_probe(struct platform_device *pdev)
>>
>> platform_set_drvdata(pdev, bci);
>>
>> + INIT_WORK(&bci->work, twl4030_bci_usb_work);
>> + INIT_DELAYED_WORK(&bci->current_worker, twl4030_current_worker);
>> +
>> bci->channel_vac = devm_iio_channel_get(&pdev->dev, "vac");
>> if (IS_ERR(bci->channel_vac)) {
>> bci->channel_vac = NULL;
>> dev_warn(&pdev->dev, "could not request vac iio channel");
>> }
>>
>> + if (bci->dev->of_node) {
>> + struct device_node *phynode;
>> +
>> + phynode = of_find_compatible_node(bci->dev->of_node->parent,
>> + NULL, "ti,twl4030-usb");
>> + if (phynode) {
>> + bci->transceiver = devm_usb_get_phy_by_node(
>> + bci->dev, phynode, &bci->usb_nb);
>> + bci->usb_nb.notifier_call = twl4030_bci_usb_ncb;
>
> those two should be the other way around.
Seems to work as well (and avoids another potential race condition).
v8 coming instantly.
BR and thanks,
Nikolaus
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-07-03 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 8:41 [PATCH v7 0/2] More fixes for twl4030 charger H. Nikolaus Schaller
2017-06-19 8:41 ` [PATCH v7 1/2] power: supply: twl4030-charger: move irq allocation to just before irqs are enabled H. Nikolaus Schaller
2017-07-03 12:55 ` Sebastian Reichel
2017-07-03 16:36 ` H. Nikolaus Schaller [this message]
2017-06-19 8:41 ` [PATCH v7 2/2] power: supply: twl4030-charger: add deferred probing for phy and iio H. Nikolaus Schaller
2017-07-03 12:59 ` Sebastian Reichel
2017-07-01 11:49 ` [PATCH v7 0/2] More fixes for twl4030 charger H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6B48E0E0-3AA6-4815-A549-868B57614F51@goldelico.com \
--to=hns@goldelico.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=neil@brown.name \
--cc=notasas@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).