From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Kate Hsuan <hpa@redhat.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com,
Mark Gross <mgross@linux.intel.com>,
Alex Hung <alex.hung@canonical.com>,
Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
David E Box <david.e.box@intel.com>,
Zha Qipeng <qipeng.zha@intel.com>,
"David E. Box" <david.e.box@linux.intel.com>,
AceLan Kao <acelan.kao@canonical.com>,
Jithu Joseph <jithu.joseph@intel.com>,
Maurice Ma <maurice.ma@intel.com>
Subject: Re: [PATCH v5 07/20] platform/x86: pmc_atom: Move to intel sub-directory
Date: Mon, 23 Aug 2021 09:35:23 +0200 [thread overview]
Message-ID: <6a2c03a2-cb25-5e64-04bd-0e387c2d4cb1@redhat.com> (raw)
In-Reply-To: <YSNPGRt6azqfXFKP@smile.fi.intel.com>
Hi,
On 8/23/21 9:32 AM, Andy Shevchenko wrote:
> On Fri, Aug 20, 2021 at 08:18:17PM +0200, Hans de Goede wrote:
>> On 8/20/21 1:04 PM, Andy Shevchenko wrote:
>>> Move Intel Atom PMC driver to intel sub-directory to improve readability.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> This means that pmc_atom will now not be build if X86_PLATFORM_DRIVERS_INTEL
>> is not set (and PCI is enabled). Which will cause missing pmc_atom_read/_write
>> symbols in drivers/acpi/acpi_lpss.c. So I have dropped this patch from the
>> set, while applying the rest.
>>
>> Note I'm thinking that we should just remove the whole X86_PLATFORM_DRIVERS_INTEL
>> Kconfig option and in the drivers/platform/x86/Makefile replace:
>>
>> obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/
>>
>> with:
>>
>> obj-y += intel/
>>
>> This will also allows us to fix the scu issue without needing any
>> changes to drivers/mfd/Kconfig .
>>
>> But this can all wait for the 2nd round of renames after 5.15-rc1.
>>
>> For now I'm moving forward with this v5 series, except with this
>> patch dropped.
>
> Indeed. Thanks for the analysis.
>
> Btw, should we convert Dell subdir to something similar in terms of Kconfig?
I'm not sure, if someone is trying to build a minimal kernel then being able
to say 'N' once for all the Dell drivers make sense. OTOH even someone
building a minimal (x86) config very likely still needs some of the Intel
drivers.
So I think we should just keep the Dell bits as is.
Regards,
Hans
>
next prev parent reply other threads:[~2021-08-23 7:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 11:04 [PATCH v5 00/20] platform/x86: Intel platform driver code movement Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 01/20] platform/x86: intel_scu_ipc: Fix doc of intel_scu_ipc_dev_command_with_size() Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 02/20] platform/x86: intel_bxtwc_tmu: Move to intel sub-directory Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 03/20] platform/x86: intel_chtdc_ti_pwrbtn: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 04/20] platform/x86: intel_mrfld_pwrbtn: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 05/20] platform/x86: intel_punit_ipc: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 06/20] platform/x86: intel_pmc_core: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 07/20] platform/x86: pmc_atom: " Andy Shevchenko
2021-08-20 18:18 ` Hans de Goede
2021-08-23 7:32 ` Andy Shevchenko
2021-08-23 7:35 ` Hans de Goede [this message]
2021-08-20 11:04 ` [PATCH v5 08/20] platform/x86: intel_telemetry: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 09/20] platform/x86: intel-rst: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 10/20] platform/x86: intel-smartconnect: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 11/20] platform/x86: intel_turbo_max_3: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 12/20] platform/x86: intel-uncore-frequency: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 13/20] platform/x86: intel_speed_select_if: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 14/20] platform/x86: intel_atomisp2: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 15/20] platform/x86: intel-hid: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 16/20] platform/x86: intel_int0002_vgpio: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 17/20] platform/x86: intel_oaktrail: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 18/20] platform/x86: intel-vbtn: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 19/20] platform/x86: intel-wmi-sbl-fw-update: " Andy Shevchenko
2021-08-20 11:04 ` [PATCH v5 20/20] platform/x86: intel-wmi-thunderbolt: " Andy Shevchenko
2021-08-20 18:38 ` [PATCH v5 00/20] platform/x86: Intel platform driver code movement Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2c03a2-cb25-5e64-04bd-0e387c2d4cb1@redhat.com \
--to=hdegoede@redhat.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=acelan.kao@canonical.com \
--cc=alex.hung@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david.e.box@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hpa@redhat.com \
--cc=irenic.rajneesh@gmail.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maurice.ma@intel.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).