From: lifonghsu <lifonghsu@synology.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: net: fix routing encapsulated packets when binding a socket to a tunnel interface
Date: Mon, 01 Apr 2019 17:52:34 +0800 [thread overview]
Message-ID: <6c73524bdddc66f9959243a5a4ce2827@synology.com> (raw)
In-Reply-To: <20190331.230123.1312457672309077256.davem@davemloft.net>
David Miller 於 2019-04-01 14:01 寫到:
> From: lifonghsu <lifonghsu@synology.com>
> Date: Mon, 01 Apr 2019 11:00:22 +0800
>
>> Since we are not sure whether there is any code referring to the
>> value of skb_iff in transmit site or not, it is risky to set an
>> invalid interface
>
> If you are no confident in how the value is used on TX, then I can't
> consider your change with confidence either.
>
> Think about what you are saying to me here. You basically do not know
> whether you are adding a bug or not.
Indeed, we are not confident about the commit. Please drop it for now.
Thank you for help review the commit.
prev parent reply other threads:[~2019-04-01 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 6:29 net: fix routing encapsulated packets when binding a socket to a tunnel interface lifonghsu
2019-03-25 23:16 ` David Miller
2019-03-27 20:44 ` David Miller
2019-03-28 8:30 ` lifonghsu
2019-03-29 17:40 ` David Miller
2019-04-01 3:00 ` lifonghsu
2019-04-01 6:01 ` David Miller
2019-04-01 9:52 ` lifonghsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c73524bdddc66f9959243a5a4ce2827@synology.com \
--to=lifonghsu@synology.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).