From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
kernel@pengutronix.de, andy.shevchenko@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] driver core: add helper for deferred probe reason setting
Date: Tue, 23 Mar 2021 16:27:06 +0100 [thread overview]
Message-ID: <6d1b5540-0541-114b-a73c-018d7fc9b403@pengutronix.de> (raw)
In-Reply-To: <YFn2Kffl0F8yeclC@kroah.com>
Hello,
On 23.03.21 15:07, Greg Kroah-Hartman wrote:
> On Fri, Mar 19, 2021 at 12:04:58PM +0100, Ahmad Fatoum wrote:
>> We now have three places within the same file doing the same operation
>> of freeing this pointer and setting it anew. A helper make this
>> arguably easier to read, so add one.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>> v1 -> v2:
>> - no change
>> ---
>> drivers/base/dd.c | 17 +++++++++++------
>> 1 file changed, 11 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
>> index e2cf3b29123e..4201baa1cc13 100644
>> --- a/drivers/base/dd.c
>> +++ b/drivers/base/dd.c
>> @@ -69,6 +69,12 @@ static char async_probe_drv_names[ASYNC_DRV_NAMES_MAX_LEN];
>> */
>> static bool defer_all_probes;
>>
>> +static void __device_set_deferred_probe_reason(const struct device *dev, char *reason)
>> +{
>> + kfree(dev->p->deferred_probe_reason);
>> + dev->p->deferred_probe_reason = reason;
>> +}
>> +
>> /*
>> * deferred_probe_work_func() - Retry probing devices in the active list.
>> */
>> @@ -97,8 +103,7 @@ static void deferred_probe_work_func(struct work_struct *work)
>>
>> get_device(dev);
>>
>> - kfree(dev->p->deferred_probe_reason);
>> - dev->p->deferred_probe_reason = NULL;
>> + __device_set_deferred_probe_reason(dev, NULL);
>>
>> /*
>> * Drop the mutex while probing each device; the probe path may
>> @@ -140,8 +145,7 @@ void driver_deferred_probe_del(struct device *dev)
>> if (!list_empty(&dev->p->deferred_probe)) {
>> dev_dbg(dev, "Removed from deferred list\n");
>> list_del_init(&dev->p->deferred_probe);
>> - kfree(dev->p->deferred_probe_reason);
>> - dev->p->deferred_probe_reason = NULL;
>> + __device_set_deferred_probe_reason(dev, NULL);
>> }
>> mutex_unlock(&deferred_probe_mutex);
>> }
>> @@ -220,11 +224,12 @@ void device_unblock_probing(void)
>> void device_set_deferred_probe_reason(const struct device *dev, struct va_format *vaf)
>> {
>> const char *drv = dev_driver_string(dev);
>> + char *reason;
>>
>> mutex_lock(&deferred_probe_mutex);
>>
>> - kfree(dev->p->deferred_probe_reason);
>> - dev->p->deferred_probe_reason = kasprintf(GFP_KERNEL, "%s: %pV", drv, vaf);
>> + reason = kasprintf(GFP_KERNEL, "%s: %pV", drv, vaf);
>
> No error checking?
There wasn't any before and I think silent failure to set the defer reason
is completely adequate behavior.
Cheers,
Ahmad
>
> :(
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-03-23 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210319110516eucas1p1d4e5152af8a1873f192f4edba8cfbb8f@eucas1p1.samsung.com>
2021-03-19 11:04 ` [PATCH v2 1/2] driver core: clear deferred probe reason on probe retry Ahmad Fatoum
2021-03-19 11:04 ` [PATCH v2 2/2] driver core: add helper for deferred probe reason setting Ahmad Fatoum
2021-03-19 11:13 ` Andy Shevchenko
2021-03-19 11:46 ` Ahmad Fatoum
2021-03-19 12:16 ` Andy Shevchenko
2021-03-19 16:08 ` Ahmad Fatoum
2021-03-19 11:15 ` Andy Shevchenko
2021-03-19 11:47 ` Ahmad Fatoum
2021-03-23 14:07 ` Greg Kroah-Hartman
2021-03-23 15:27 ` Ahmad Fatoum [this message]
2021-03-22 8:18 ` [PATCH v2 1/2] driver core: clear deferred probe reason on probe retry Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1b5540-0541-114b-a73c-018d7fc9b403@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).