From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: greg@enjellic.com, linux-kernel@vger.kernel.org
Cc: dgdegra@tycho.nsa.gov, konrad.wilk@oracle.com,
jarkko.sakkinen@linux.intel.com
Subject: Re: [PATCH] tpm: Restore functionality to xen vtpm driver.
Date: Fri, 20 Jan 2017 17:22:25 -0500 [thread overview]
Message-ID: <6e0dd5d8-0aca-e85d-5f0a-5306e4f4ba16@oracle.com> (raw)
In-Reply-To: <201701201500.v0KF02N1027871@wind.enjellic.com>
On 01/20/2017 10:00 AM, Dr. Greg Wettstein wrote:
> Functionality of the xen-tpmfront driver was lost secondary to
> the introduction of xenbus multi-page support in the following
> commit:
>
> ccc9d90a9a8b5c4ad7e9708ec41f75ff9e98d61d
>
> xenbus_client: Extend interface to support multi-page ring
>
> In this commit a pointer to the shared page address was being
> passed to the xenbus_grant_ring() function rather then the
> address of the shared page itself. This resulted in a situation
> where the driver would attach to the vtpm-stubdom but any attempt
> to send a command to the stub domain would timeout.
>
> A diagnostic finding for this regression is the following error
> message being generated when the xen-tpmfront driver probes for a
> device:
>
> <3>vtpm vtpm-0: tpm_transmit: tpm_send: error -62
>
> <3>vtpm vtpm-0: A TPM error (-62) occurred attempting to determine the timeouts
>
> This fix is relevant to all kernels from 4.1 forward which is the
> release in which multi-page xenbus support was introduced.
>
> Daniel De Graaf formulated the fix by code inspection after the
> regression point was located.
>
> Cc: <stable@vger.kernel.org> # 4.1-
4.1+, I believe.
> Suggested-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Signed-off-by: Dr. Greg Wettstein <greg@enjellic.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
> drivers/char/tpm/xen-tpmfront.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 3111f2778079..d1478f7b3f97 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -201,7 +201,7 @@ static int setup_ring(struct xenbus_device *dev, struct tpm_private *priv)
> return -ENOMEM;
> }
>
> - rv = xenbus_grant_ring(dev, &priv->shr, 1, &gref);
> + rv = xenbus_grant_ring(dev, priv->shr, 1, &gref);
> if (rv < 0)
> return rv;
>
next prev parent reply other threads:[~2017-01-20 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 15:00 [PATCH] tpm: Restore functionality to xen vtpm driver Dr. Greg Wettstein
2017-01-20 22:22 ` Boris Ostrovsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-21 0:29 Dr. Greg Wettstein
2016-12-22 20:41 Dr. Greg Wettstein
2016-12-23 7:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0dd5d8-0aca-e85d-5f0a-5306e4f4ba16@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=greg@enjellic.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).